diff options
author | Ruben Bridgewater <ruben@bridgewater.de> | 2018-05-31 12:11:22 +0200 |
---|---|---|
committer | Anna Henningsen <anna@addaleax.net> | 2018-06-08 01:24:39 +0200 |
commit | 32c51f10d33c686f2607559ff24a97d6c4a6f109 (patch) | |
tree | 0563de6d86fbebc4d9de2c461f645f2f3a8e4989 /test | |
parent | 505bfdc7e4fc4f914ceca019706dbf06901dd361 (diff) | |
download | android-node-v8-32c51f10d33c686f2607559ff24a97d6c4a6f109.tar.gz android-node-v8-32c51f10d33c686f2607559ff24a97d6c4a6f109.tar.bz2 android-node-v8-32c51f10d33c686f2607559ff24a97d6c4a6f109.zip |
stream: make the pipeline callback mandatory
Right now when not adding a callback to the pipeline it could cause
an uncaught exception if there is an error. Instead, just make the
callback mandatory as mostly done in all other Node.js callback APIs
so users explicitly have to decide what to do in such situations.
PR-URL: https://github.com/nodejs/node/pull/21054
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaƫl Zasso <targos@protonmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'test')
-rw-r--r-- | test/parallel/test-stream-pipeline.js | 19 |
1 files changed, 5 insertions, 14 deletions
diff --git a/test/parallel/test-stream-pipeline.js b/test/parallel/test-stream-pipeline.js index 12733d88a7..f735054e88 100644 --- a/test/parallel/test-stream-pipeline.js +++ b/test/parallel/test-stream-pipeline.js @@ -60,7 +60,7 @@ common.crashOnUnhandledRejection(); }, /ERR_MISSING_ARGS/); assert.throws(() => { pipeline(); - }, /ERR_MISSING_ARGS/); + }, /ERR_INVALID_CALLBACK/); } { @@ -493,17 +493,8 @@ common.crashOnUnhandledRejection(); } }); - read.on('close', common.mustCall()); - transform.on('close', common.mustCall()); - write.on('close', common.mustCall()); - - process.on('uncaughtException', common.mustCall((err) => { - assert.deepStrictEqual(err, new Error('kaboom')); - })); - - const dst = pipeline(read, transform, write); - - assert.strictEqual(dst, write); - - read.push('hello'); + assert.throws( + () => pipeline(read, transform, write), + { code: 'ERR_INVALID_CALLBACK' } + ); } |