summaryrefslogtreecommitdiff
path: root/test
diff options
context:
space:
mode:
authorRich Trott <rtrott@gmail.com>2016-04-01 21:40:21 -0700
committerRich Trott <rtrott@gmail.com>2016-04-04 14:18:49 -0700
commit263222da49ce5256c8eb5afe39c6ef5c2dac200e (patch)
treeac3e54b2316c795e621240dae65111712b281401 /test
parentc60faf6ba85b6365145fd8215ed572efa9f25fdc (diff)
downloadandroid-node-v8-263222da49ce5256c8eb5afe39c6ef5c2dac200e.tar.gz
android-node-v8-263222da49ce5256c8eb5afe39c6ef5c2dac200e.tar.bz2
android-node-v8-263222da49ce5256c8eb5afe39c6ef5c2dac200e.zip
test: fix pummel test failures
A handful of tests in `test/pummel` were failing due to undefined variables. The tests in pummel are not run in CI or otherwise exercised regularly so these failures can go unnoticed for a long time. PR-URL: https://github.com/nodejs/node/pull/6012 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Diffstat (limited to 'test')
-rw-r--r--test/pummel/test-crypto-dh.js5
-rw-r--r--test/pummel/test-dtrace-jsstack.js2
-rw-r--r--test/pummel/test-net-throttle.js12
3 files changed, 10 insertions, 9 deletions
diff --git a/test/pummel/test-crypto-dh.js b/test/pummel/test-crypto-dh.js
index 8d732ed92e..6ebfb878be 100644
--- a/test/pummel/test-crypto-dh.js
+++ b/test/pummel/test-crypto-dh.js
@@ -1,6 +1,7 @@
'use strict';
-var common = require('../common');
-var assert = require('assert');
+const common = require('../common');
+const assert = require('assert');
+const crypto = require('crypto');
if (!common.hasCrypto) {
console.log('1..0 # Skipped: node compiled without OpenSSL.');
diff --git a/test/pummel/test-dtrace-jsstack.js b/test/pummel/test-dtrace-jsstack.js
index 2e5c867055..f53c950baa 100644
--- a/test/pummel/test-dtrace-jsstack.js
+++ b/test/pummel/test-dtrace-jsstack.js
@@ -14,7 +14,7 @@ if (os.type() != 'SunOS') {
var frames = [ 'stalloogle', 'bagnoogle', 'doogle' ];
var stalloogle = function(str) {
- expected = str;
+ global.expected = str;
os.loadavg();
};
diff --git a/test/pummel/test-net-throttle.js b/test/pummel/test-net-throttle.js
index e98a6c765a..d2f32ec25b 100644
--- a/test/pummel/test-net-throttle.js
+++ b/test/pummel/test-net-throttle.js
@@ -1,15 +1,15 @@
'use strict';
-var common = require('../common');
-var assert = require('assert');
-var net = require('net');
+const common = require('../common');
+const assert = require('assert');
+const net = require('net');
-var N = 1024 * 1024;
-var part_N = N / 3;
+const N = 1024 * 1024;
+const part_N = N / 3;
var chars_recved = 0;
var npauses = 0;
console.log('build big string');
-body = 'C'.repeat(N);
+const body = 'C'.repeat(N);
console.log('start server on port ' + common.PORT);