diff options
author | Masashi Hirano <cherrydog07@gmail.com> | 2018-05-30 00:57:18 +0900 |
---|---|---|
committer | Lance Ball <lball@redhat.com> | 2018-06-04 11:44:28 -0400 |
commit | 262f3777cefdba21987947b56827c3b8112fe5ba (patch) | |
tree | 53709c4d0406bb6ab866bcf4e110a4af9441594b /test | |
parent | 42adb65d2f350e5b553c25ef8543fabe5cf9688b (diff) | |
download | android-node-v8-262f3777cefdba21987947b56827c3b8112fe5ba.tar.gz android-node-v8-262f3777cefdba21987947b56827c3b8112fe5ba.tar.bz2 android-node-v8-262f3777cefdba21987947b56827c3b8112fe5ba.zip |
test: improve internal/buffer.js test coverage
Added tests buffer.js methods to write 48 bit value to
improve test coverage.
PR-URL: https://github.com/nodejs/node/pull/21061
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Lance Ball <lball@redhat.com>
Diffstat (limited to 'test')
-rw-r--r-- | test/parallel/test-buffer-readint.js | 2 | ||||
-rw-r--r-- | test/parallel/test-buffer-readuint.js | 2 | ||||
-rw-r--r-- | test/parallel/test-buffer-writeint.js | 15 | ||||
-rw-r--r-- | test/parallel/test-buffer-writeuint.js | 11 |
4 files changed, 28 insertions, 2 deletions
diff --git a/test/parallel/test-buffer-readint.js b/test/parallel/test-buffer-readint.js index d417f88b82..971dd3bb95 100644 --- a/test/parallel/test-buffer-readint.js +++ b/test/parallel/test-buffer-readint.js @@ -160,7 +160,7 @@ const assert = require('assert'); }); // Test 1 to 6 bytes. - for (let i = 1; i < 6; i++) { + for (let i = 1; i <= 6; i++) { ['readIntBE', 'readIntLE'].forEach((fn) => { ['', '0', null, {}, [], () => {}, true, false, undefined].forEach((o) => { assert.throws( diff --git a/test/parallel/test-buffer-readuint.js b/test/parallel/test-buffer-readuint.js index d2c07e4de8..de683f0950 100644 --- a/test/parallel/test-buffer-readuint.js +++ b/test/parallel/test-buffer-readuint.js @@ -128,7 +128,7 @@ const assert = require('assert'); }); // Test 1 to 6 bytes. - for (let i = 1; i < 6; i++) { + for (let i = 1; i <= 6; i++) { ['readUIntBE', 'readUIntLE'].forEach((fn) => { ['', '0', null, {}, [], () => {}, true, false, undefined].forEach((o) => { assert.throws( diff --git a/test/parallel/test-buffer-writeint.js b/test/parallel/test-buffer-writeint.js index fb91aa11b6..0e5b4960ab 100644 --- a/test/parallel/test-buffer-writeint.js +++ b/test/parallel/test-buffer-writeint.js @@ -162,6 +162,21 @@ const errorOutOfBounds = common.expectsError({ }); } +// Test 48 bit +{ + const value = 0x1234567890ab; + const buffer = Buffer.allocUnsafe(6); + buffer.writeIntBE(value, 0, 6); + assert.ok(buffer.equals(new Uint8Array([ + 0x12, 0x34, 0x56, 0x78, 0x90, 0xab + ]))); + + buffer.writeIntLE(value, 0, 6); + assert.ok(buffer.equals(new Uint8Array([ + 0xab, 0x90, 0x78, 0x56, 0x34, 0x12 + ]))); +} + // Test Int { const data = Buffer.alloc(8); diff --git a/test/parallel/test-buffer-writeuint.js b/test/parallel/test-buffer-writeuint.js index 8fe7783e71..999440114c 100644 --- a/test/parallel/test-buffer-writeuint.js +++ b/test/parallel/test-buffer-writeuint.js @@ -110,6 +110,17 @@ const assert = require('assert'); assert.ok(data.equals(new Uint8Array([0x6d, 0x6d, 0x6d, 0x0a, 0xf9, 0xe7]))); } +// Test 48 bit +{ + const value = 0x1234567890ab; + const data = Buffer.allocUnsafe(6); + data.writeUIntBE(value, 0, 6); + assert.ok(data.equals(new Uint8Array([0x12, 0x34, 0x56, 0x78, 0x90, 0xab]))); + + data.writeUIntLE(value, 0, 6); + assert.ok(data.equals(new Uint8Array([0xab, 0x90, 0x78, 0x56, 0x34, 0x12]))); +} + // Test UInt { const data = Buffer.alloc(8); |