diff options
| author | peterwmwong <peter.wm.wong@gmail.com> | 2018-12-29 11:28:07 -0600 |
|---|---|---|
| committer | Anna Henningsen <anna@addaleax.net> | 2019-01-02 14:41:41 +0100 |
| commit | 2370bc7143211d860fc14e710cc8400fb4004bed (patch) | |
| tree | 2595f3a4c5fae18d93656aebe796d79718a37018 /test | |
| parent | 5fab50bdaf6d82abc8a15bc55685211431ef3b75 (diff) | |
| download | android-node-v8-2370bc7143211d860fc14e710cc8400fb4004bed.tar.gz android-node-v8-2370bc7143211d860fc14e710cc8400fb4004bed.tar.bz2 android-node-v8-2370bc7143211d860fc14e710cc8400fb4004bed.zip | |
test: remove unused --expose-native-as V8 flag
test-preload.js was using a V8 flag (`--expose-native-as`) that made
an V8 internally used object available. As this test does not use this
object, this commit removes the usage of this flag.
In some distant past, this internally used object may have had some
external use, but currently is essentially an empty object.
In the near future, the V8 internal infrastructure (JS Natives)
producing the object exposed by `--expose-native-as` will be phased out.
For more details, visit:
https://bugs.chromium.org/p/v8/issues/detail?id=7624
PR-URL: https://github.com/nodejs/node/pull/25275
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Diffstat (limited to 'test')
| -rw-r--r-- | test/parallel/test-preload.js | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/test/parallel/test-preload.js b/test/parallel/test-preload.js index 71c282b9fb..566a3eec54 100644 --- a/test/parallel/test-preload.js +++ b/test/parallel/test-preload.js @@ -155,7 +155,7 @@ if (common.isWindows) { // https://github.com/nodejs/node/issues/1691 process.chdir(fixtures.fixturesDir); childProcess.exec( - `"${nodeBinary}" --expose_natives_as=v8natives --require ` + + `"${nodeBinary}" --require ` + `"${fixtures.path('cluster-preload.js')}" cluster-preload-test.js`, function(err, stdout, stderr) { assert.ifError(err); |