diff options
author | Joyee Cheung <joyeec9h3@gmail.com> | 2019-01-13 01:03:49 +0800 |
---|---|---|
committer | Joyee Cheung <joyeec9h3@gmail.com> | 2019-01-16 21:54:26 +0800 |
commit | 2190d47d604641d26acc2ef6c1b6a9ad00afa193 (patch) | |
tree | 507e94bfe52a95ef8230c08e5adf23b4d2cc9d8c /test | |
parent | cd70cbcbddfe1a577d5cf3f2c1c754359a04b9a2 (diff) | |
download | android-node-v8-2190d47d604641d26acc2ef6c1b6a9ad00afa193.tar.gz android-node-v8-2190d47d604641d26acc2ef6c1b6a9ad00afa193.tar.bz2 android-node-v8-2190d47d604641d26acc2ef6c1b6a9ad00afa193.zip |
src: remove unused `internalBinding('config')` properties
Remove the following properties:
- `preserveSymlinks`
- `preserveSymlinksMain`
- `experimentalModules`
- `userLoader`
- `experimentalVMModules`
- `experimentalREPLAwait`
- `exposeInternals`
We used to use them to pass cli option values from C++ into
JS, but now the values are obtained in JS land using
`require('internal/options').getOptionValue` instead so they
are unused.
Also removes `test/parallel/test-internal-modules-expose.js`
which tests `--expose-internals`.
We already have hundreds of tests depending on `--expose-internals`,
they are more than enough to test the functionality of the flag.
PR-URL: https://github.com/nodejs/node/pull/25463
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Diffstat (limited to 'test')
-rw-r--r-- | test/parallel/test-internal-modules-expose.js | 12 |
1 files changed, 0 insertions, 12 deletions
diff --git a/test/parallel/test-internal-modules-expose.js b/test/parallel/test-internal-modules-expose.js deleted file mode 100644 index 5229032573..0000000000 --- a/test/parallel/test-internal-modules-expose.js +++ /dev/null @@ -1,12 +0,0 @@ -'use strict'; -// Flags: --expose_internals - -require('../common'); -const assert = require('assert'); -const { internalBinding } = require('internal/test/binding'); -const config = internalBinding('config'); - -console.log(config, process.argv); - -assert.strictEqual(typeof require('internal/freelist').FreeList, 'function'); -assert.strictEqual(config.exposeInternals, true); |