tls: honor pauseOnConnect option

`pauseOnConnect` is now passed along to the net.Socket constructor from
the tls.Socket constructor. The `readable` flag must match the value of
`pauseOnConnect`. Tests were added to cover all available net.Server
options when used in the tls.Server constructor.

Fixes: https://github.com/nodejs/node/issues/29620
Refs: https://github.com/nodejs/node/pull/27665

PR-URL: https://github.com/nodejs/node/pull/29635
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

1 files changed, 5 insertions, 0 deletions

diff --git a/test/parallel/test-tls-server-parent-constructor-options.js b/test/parallel/test-tls-server-parent-constructor-options.js
index 17484c29ba..f8b34e8b0c 100644
--- a/test/parallel/test-tls-server-parent-constructor-options.js
+++ b/test/parallel/test-tls-server-parent-constructor-options.js
@@ -19,9 +19,11 @@ const options = {
 {
   const server = tls.createServer(options, common.mustCall((socket) => {
     assert.strictEqual(socket.allowHalfOpen, false);
+    assert.strictEqual(socket.isPaused(), false);
   }));
 
   assert.strictEqual(server.allowHalfOpen, false);
+  assert.strictEqual(server.pauseOnConnect, false);
 
   server.listen(0, common.mustCall(() => {
     const socket = tls.connect({
@@ -40,13 +42,16 @@ const options = {
 {
   const server = tls.createServer({
     allowHalfOpen: true,
+    pauseOnConnect: true,
     ...options
   }, common.mustCall((socket) => {
     assert.strictEqual(socket.allowHalfOpen, true);
+    assert.strictEqual(socket.isPaused(), true);
     socket.on('end', socket.end);
   }));
 
   assert.strictEqual(server.allowHalfOpen, true);
+  assert.strictEqual(server.pauseOnConnect, true);
 
   server.listen(0, common.mustCall(() => {
     const socket = tls.connect({