diff options
author | Richard Lau <riclau@uk.ibm.com> | 2019-05-10 21:47:01 -0400 |
---|---|---|
committer | Richard Lau <riclau@uk.ibm.com> | 2019-05-13 16:07:34 -0400 |
commit | 1df3080af393a338df4cfbb56b442fe4b8345495 (patch) | |
tree | bf3863717ae1f08872eb7faf80337273c6ab8461 /test | |
parent | ef51cc8ac937ac44bfe8b8ec000b7f04f170abd5 (diff) | |
download | android-node-v8-1df3080af393a338df4cfbb56b442fe4b8345495.tar.gz android-node-v8-1df3080af393a338df4cfbb56b442fe4b8345495.tar.bz2 android-node-v8-1df3080af393a338df4cfbb56b442fe4b8345495.zip |
tools: allow RegExp in required-modules eslint rule
PR-URL: https://github.com/nodejs/node/pull/27647
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaƫl Zasso <targos@protonmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Diffstat (limited to 'test')
-rw-r--r-- | test/.eslintrc.yaml | 4 | ||||
-rw-r--r-- | test/parallel/test-eslint-required-modules.js | 22 |
2 files changed, 22 insertions, 4 deletions
diff --git a/test/.eslintrc.yaml b/test/.eslintrc.yaml index 8eee5f3995..8a36ac522a 100644 --- a/test/.eslintrc.yaml +++ b/test/.eslintrc.yaml @@ -21,7 +21,9 @@ rules: node-core/inspector-check: error node-core/number-isnan: error ## common module is mandatory in tests - node-core/required-modules: [error, common] + node-core/required-modules: + - error + - common: 'common(/index\.(m)?js)?$' node-core/require-common-first: error node-core/no-duplicate-requires: off diff --git a/test/parallel/test-eslint-required-modules.js b/test/parallel/test-eslint-required-modules.js index 6b2b0d9502..e81a7d4b24 100644 --- a/test/parallel/test-eslint-required-modules.js +++ b/test/parallel/test-eslint-required-modules.js @@ -13,22 +13,38 @@ new RuleTester().run('required-modules', rule, { valid: [ { code: 'require("common")', - options: ['common'] + options: [{ common: 'common' }] }, { code: 'foo', options: [] }, + { + code: 'require("common")', + options: [{ common: 'common(/index\\.(m)?js)?$' }] + }, + { + code: 'require("common/index.js")', + options: [{ common: 'common(/index\\.(m)?js)?$' }] + }, ], invalid: [ { code: 'foo', - options: ['common'], + options: [{ common: 'common' }], errors: [{ message: 'Mandatory module "common" must be loaded.' }] }, { + code: 'require("common/fixtures.js")', + options: [{ common: 'common(/index\\.(m)?js)?$' }], + errors: [{ + message: + 'Mandatory module "common" must be loaded.' + }] + }, + { code: 'require("somethingElse")', - options: ['common'], + options: [{ common: 'common' }], errors: [{ message: 'Mandatory module "common" must be loaded.' }] } ] |