summaryrefslogtreecommitdiff
path: root/test/sequential
diff options
context:
space:
mode:
authorcjihrig <cjihrig@gmail.com>2019-02-21 16:27:46 -0500
committercjihrig <cjihrig@gmail.com>2019-02-26 16:44:47 -0500
commite3d4a7d9994ff7d1bd144779f8b91d8302112bc0 (patch)
treeb5530921f0ac4de358c343454a803ff0c99439a4 /test/sequential
parentd7a3c3cecc67f0ddb36734f305994981b1cf9ba2 (diff)
downloadandroid-node-v8-e3d4a7d9994ff7d1bd144779f8b91d8302112bc0.tar.gz
android-node-v8-e3d4a7d9994ff7d1bd144779f8b91d8302112bc0.tar.bz2
android-node-v8-e3d4a7d9994ff7d1bd144779f8b91d8302112bc0.zip
inspector: return Error objects on error
The inspector communicates errors via POJOs. This commit wraps the error information in an actual Error object. PR-URL: https://github.com/nodejs/node/pull/26255 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Diffstat (limited to 'test/sequential')
-rw-r--r--test/sequential/test-inspector-runtime-evaluate-with-timeout.js17
1 files changed, 11 insertions, 6 deletions
diff --git a/test/sequential/test-inspector-runtime-evaluate-with-timeout.js b/test/sequential/test-inspector-runtime-evaluate-with-timeout.js
index 1def39a82f..79c746540b 100644
--- a/test/sequential/test-inspector-runtime-evaluate-with-timeout.js
+++ b/test/sequential/test-inspector-runtime-evaluate-with-timeout.js
@@ -5,17 +5,22 @@ const common = require('../common');
common.skipIfInspectorDisabled();
(async function test() {
- const { strictEqual } = require('assert');
+ const assert = require('assert');
const { Session } = require('inspector');
const { promisify } = require('util');
const session = new Session();
session.connect();
session.post = promisify(session.post);
- const result = await session.post('Runtime.evaluate', {
- expression: 'for(;;);',
- timeout: 0
- }).catch((e) => e);
- strictEqual(result.message, 'Execution was terminated');
+ await assert.rejects(
+ session.post('Runtime.evaluate', {
+ expression: 'for(;;);',
+ timeout: 0
+ }),
+ {
+ code: 'ERR_INSPECTOR_COMMAND',
+ message: 'Inspector error -32000: Execution was terminated'
+ }
+ );
session.disconnect();
})();