summaryrefslogtreecommitdiff
path: root/test/sequential
diff options
context:
space:
mode:
authorRuben Bridgewater <ruben@bridgewater.de>2018-12-03 17:15:45 +0100
committerRuben Bridgewater <ruben@bridgewater.de>2018-12-10 17:07:18 +0100
commit1f85ea979ccef3c52ec4ca3263306e527b625498 (patch)
treef318be6ee905b1a04d1d2db859720c4b33b22aa8 /test/sequential
parentcc8250fab86486632fdeb63892be735d7628cd13 (diff)
downloadandroid-node-v8-1f85ea979ccef3c52ec4ca3263306e527b625498.tar.gz
android-node-v8-1f85ea979ccef3c52ec4ca3263306e527b625498.tar.bz2
android-node-v8-1f85ea979ccef3c52ec4ca3263306e527b625498.zip
tools: capitalize sentences
This adds the `capitalized-comments` eslint rule to verify that actual sentences use capital letters as starting letters. It ignores special words and all lines below 62 characters. PR-URL: https://github.com/nodejs/node/pull/24808 Reviewed-By: Sam Ruby <rubys@intertwingly.net> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Diffstat (limited to 'test/sequential')
-rw-r--r--test/sequential/test-cli-syntax.js2
-rw-r--r--test/sequential/test-http-max-http-headers.js4
-rw-r--r--test/sequential/test-init.js4
-rw-r--r--test/sequential/test-inspector.js6
4 files changed, 8 insertions, 8 deletions
diff --git a/test/sequential/test-cli-syntax.js b/test/sequential/test-cli-syntax.js
index 35cc78258d..74e8c9fa91 100644
--- a/test/sequential/test-cli-syntax.js
+++ b/test/sequential/test-cli-syntax.js
@@ -112,7 +112,7 @@ syntaxArgs.forEach(function(args) {
assert.strictEqual(c.status, 0);
});
-// should throw if code piped from stdin with --check has bad syntax
+// Should throw if code piped from stdin with --check has bad syntax
// loop each possible option, `-c` or `--check`
syntaxArgs.forEach(function(args) {
const stdin = 'var foo bar;';
diff --git a/test/sequential/test-http-max-http-headers.js b/test/sequential/test-http-max-http-headers.js
index 1dece8beed..64358e8140 100644
--- a/test/sequential/test-http-max-http-headers.js
+++ b/test/sequential/test-http-max-http-headers.js
@@ -27,8 +27,8 @@ function finished(client, callback) {
}
function fillHeaders(headers, currentSize, valid = false) {
- // llhttp counts actual header name/value sizes, excluding the whitespace and
- // stripped chars.
+ // `llhttp` counts actual header name/value sizes, excluding the whitespace
+ // and stripped chars.
if (getOptionValue('--http-parser') === 'llhttp') {
// OK, Content-Length, 0, X-CRASH, aaa...
headers += 'a'.repeat(MAX - currentSize);
diff --git a/test/sequential/test-init.js b/test/sequential/test-init.js
index 1b1b09ee83..a86a1fd045 100644
--- a/test/sequential/test-init.js
+++ b/test/sequential/test-init.js
@@ -43,7 +43,7 @@ function test(file, expected) {
}
{
- // change CWD as we do this test so it's not dependent on current CWD
+ // Change CWD as we do this test so it's not dependent on current CWD
// being in the test folder
process.chdir(__dirname);
test('test-init', 'Loaded successfully!');
@@ -57,7 +57,7 @@ function test(file, expected) {
}
{
- // ensures that `node fs` does not mistakenly load the native 'fs' module
+ // Ensures that `node fs` does not mistakenly load the native 'fs' module
// instead of the desired file and that the fs module loads as
// expected in node
process.chdir(fixtures.path('test-init-native'));
diff --git a/test/sequential/test-inspector.js b/test/sequential/test-inspector.js
index 00fdb000e9..237b65193f 100644
--- a/test/sequential/test-inspector.js
+++ b/test/sequential/test-inspector.js
@@ -171,7 +171,7 @@ async function testCommandLineAPI(session) {
const printBModulePath = require.resolve('../fixtures/printB.js');
const printBModuleStr = JSON.stringify(printBModulePath);
- // we can use `require` outside of a callframe with require in scope
+ // We can use `require` outside of a callframe with require in scope
let result = await session.send(
{
'method': 'Runtime.evaluate', 'params': {
@@ -182,7 +182,7 @@ async function testCommandLineAPI(session) {
checkException(result);
assert.strictEqual(result.result.value, true);
- // the global require has the same properties as a normal `require`
+ // The global require has the same properties as a normal `require`
result = await session.send(
{
'method': 'Runtime.evaluate', 'params': {
@@ -273,7 +273,7 @@ async function testCommandLineAPI(session) {
parentsEqual: true,
parentId: '<inspector console>'
});
- // the `require` in the module shadows the command line API's `require`
+ // The `require` in the module shadows the command line API's `require`
result = await session.send(
{
'method': 'Debugger.evaluateOnCallFrame', 'params': {