summaryrefslogtreecommitdiff
path: root/test/sequential/test-timers-blocking-callback.js
diff options
context:
space:
mode:
authorAnatoli Papirovski <apapirovski@mac.com>2018-05-13 17:42:22 +0200
committerAnatoli Papirovski <apapirovski@mac.com>2018-06-24 21:35:05 -0700
commit2930bd1317d15d12738a4896c0a6c05700411b47 (patch)
tree5c9225b9740c79d83ea2ded69d63b94a66846036 /test/sequential/test-timers-blocking-callback.js
parent6f63f8d730c8c3b19de7a591c35d376d428a4d56 (diff)
downloadandroid-node-v8-2930bd1317d15d12738a4896c0a6c05700411b47.tar.gz
android-node-v8-2930bd1317d15d12738a4896c0a6c05700411b47.tar.bz2
android-node-v8-2930bd1317d15d12738a4896c0a6c05700411b47.zip
src: refactor timers to remove TimerWrap
Refactor Timers to behave more similarly to Immediates by having a single uv_timer_t handle which is stored on the Environment. No longer expose timers in a public binding and instead make it part of the internalBinding. PR-URL: https://github.com/nodejs/node/pull/20894 Fixes: https://github.com/nodejs/node/issues/10154 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Gus Caplan <me@gus.host>
Diffstat (limited to 'test/sequential/test-timers-blocking-callback.js')
-rw-r--r--test/sequential/test-timers-blocking-callback.js5
1 files changed, 2 insertions, 3 deletions
diff --git a/test/sequential/test-timers-blocking-callback.js b/test/sequential/test-timers-blocking-callback.js
index 435b69d1fa..3d05a538ea 100644
--- a/test/sequential/test-timers-blocking-callback.js
+++ b/test/sequential/test-timers-blocking-callback.js
@@ -25,7 +25,6 @@
const common = require('../common');
const assert = require('assert');
-const Timer = process.binding('timer_wrap').Timer;
const TIMEOUT = 100;
@@ -49,7 +48,7 @@ function blockingCallback(retry, callback) {
++nbBlockingCallbackCalls;
if (nbBlockingCallbackCalls > 1) {
- latestDelay = Timer.now() - timeCallbackScheduled;
+ latestDelay = Date.now() - timeCallbackScheduled;
// Even if timers can fire later than when they've been scheduled
// to fire, they shouldn't generally be more than 100% late in this case.
// But they are guaranteed to be at least 100ms late given the bug in
@@ -68,7 +67,7 @@ function blockingCallback(retry, callback) {
// block by busy-looping to trigger the issue
common.busyLoop(TIMEOUT);
- timeCallbackScheduled = Timer.now();
+ timeCallbackScheduled = Date.now();
setTimeout(blockingCallback.bind(null, retry, callback), TIMEOUT);
}
}