diff options
author | Jon Moss <me@jonathanmoss.me> | 2017-09-01 12:37:41 -0400 |
---|---|---|
committer | Ruben Bridgewater <ruben@bridgewater.de> | 2017-09-10 23:56:30 -0300 |
commit | af15b755c08370d4224541205f9e3e9ff54a4325 (patch) | |
tree | 00da6ddcf5ad8650b2852da3542f59872c230d64 /test/sequential/test-net-localport.js | |
parent | 45357d055694000b78a27e1959f304f5838005be (diff) | |
download | android-node-v8-af15b755c08370d4224541205f9e3e9ff54a4325.tar.gz android-node-v8-af15b755c08370d4224541205f9e3e9ff54a4325.tar.bz2 android-node-v8-af15b755c08370d4224541205f9e3e9ff54a4325.zip |
test: move common.PORT tests to sequential
Reasons:
- `test-async-wrap-getasyncid` binds a handle, so move to
sequential because port cannot be already in use.
- `test-dgram-implicit-bind-failure` requires a hardcoded
port number to properly send socket packet.
- `test-http-agent-uninitialized-with-handle` requires a
hardcoded port number to properly send http request.
- `test-http-agent-uninitialized` requires a hardcoded port
number to properly send http request.
- `test-net-localport` requires a hardcoded port number
for assertions.
In addition this replaces two common.PORTs with a dynamic port.
PR-URL: https://github.com/nodejs/node/pull/15151
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Diffstat (limited to 'test/sequential/test-net-localport.js')
-rw-r--r-- | test/sequential/test-net-localport.js | 20 |
1 files changed, 20 insertions, 0 deletions
diff --git a/test/sequential/test-net-localport.js b/test/sequential/test-net-localport.js new file mode 100644 index 0000000000..e90df73e52 --- /dev/null +++ b/test/sequential/test-net-localport.js @@ -0,0 +1,20 @@ +'use strict'; +const common = require('../common'); +const assert = require('assert'); +const net = require('net'); + +const server = net.createServer(function(socket) { + assert.strictEqual(socket.remotePort, common.PORT); + socket.end(); + socket.on('close', function() { + server.close(); + }); +}).listen(0).on('listening', function() { + const client = net.connect({ + host: '127.0.0.1', + port: this.address().port, + localPort: common.PORT, + }).on('connect', function() { + assert.strictEqual(client.localPort, common.PORT); + }); +}); |