summaryrefslogtreecommitdiff
path: root/test/sequential/test-inspector-scriptparsed-context.js
diff options
context:
space:
mode:
authorMichaël Zasso <targos@protonmail.com>2018-07-17 08:23:49 +0200
committerMichaël Zasso <targos@protonmail.com>2018-07-19 08:47:28 +0200
commitdf08779e0dfa82ceb69e129ae0548e97352aaddf (patch)
treea589930afbeaf5481f3fe614eeee05fc04b7ec35 /test/sequential/test-inspector-scriptparsed-context.js
parent373aae1f86c1d061123e3aec28980aa2e7d1ebd4 (diff)
downloadandroid-node-v8-df08779e0dfa82ceb69e129ae0548e97352aaddf.tar.gz
android-node-v8-df08779e0dfa82ceb69e129ae0548e97352aaddf.tar.bz2
android-node-v8-df08779e0dfa82ceb69e129ae0548e97352aaddf.zip
test: make crashOnUnhandleRejection opt-out
This commit removes `common.crashOnUnhandledRejection()` and adds `common.disableCrashOnUnhandledRejection()`. To reduce the risk of mistakes and make writing tests that involve promises simpler, always install the unhandledRejection hook in tests and provide a way to disable it for the rare cases where it's needed. PR-URL: https://github.com/nodejs/node/pull/21849 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Diffstat (limited to 'test/sequential/test-inspector-scriptparsed-context.js')
-rw-r--r--test/sequential/test-inspector-scriptparsed-context.js1
1 files changed, 0 insertions, 1 deletions
diff --git a/test/sequential/test-inspector-scriptparsed-context.js b/test/sequential/test-inspector-scriptparsed-context.js
index abffbfe5fc..1e862e9174 100644
--- a/test/sequential/test-inspector-scriptparsed-context.js
+++ b/test/sequential/test-inspector-scriptparsed-context.js
@@ -2,7 +2,6 @@
'use strict';
const common = require('../common');
common.skipIfInspectorDisabled();
-common.crashOnUnhandledRejection();
const { NodeInstance } = require('../common/inspector-helper.js');
const assert = require('assert');