diff options
| author | Michaël Zasso <targos@protonmail.com> | 2018-03-15 14:22:36 +0100 |
|---|---|---|
| committer | Michaël Zasso <targos@protonmail.com> | 2018-03-21 20:14:57 +0100 |
| commit | ab8bf26994677a5f0823b3810668f6cfa18374d9 (patch) | |
| tree | 3f7e5a5f72d49d3fc3c1c0600c16234d15b1bda8 /test/sequential/test-inspector-port-cluster.js | |
| parent | fddcd6253b237ca68430f44c7614bf52d57c4f97 (diff) | |
| download | android-node-v8-ab8bf26994677a5f0823b3810668f6cfa18374d9.tar.gz android-node-v8-ab8bf26994677a5f0823b3810668f6cfa18374d9.tar.bz2 android-node-v8-ab8bf26994677a5f0823b3810668f6cfa18374d9.zip | |
fs,cluster,net: assign error codes to remaining errors
After this commit, all errors thrown from JS code in lib have an error
code.
PR-URL: https://github.com/nodejs/node/pull/19373
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'test/sequential/test-inspector-port-cluster.js')
| -rw-r--r-- | test/sequential/test-inspector-port-cluster.js | 25 |
1 files changed, 13 insertions, 12 deletions
diff --git a/test/sequential/test-inspector-port-cluster.js b/test/sequential/test-inspector-port-cluster.js index 87469aa7ff..dfaf59c711 100644 --- a/test/sequential/test-inspector-port-cluster.js +++ b/test/sequential/test-inspector-port-cluster.js @@ -207,6 +207,7 @@ function testRunnerMain() { function masterProcessMain() { const workers = JSON.parse(process.env.workers); const clusterSettings = JSON.parse(process.env.clusterSettings); + const badPortError = { type: RangeError, code: 'ERR_SOCKET_BAD_PORT' }; let debugPort = process.debugPort; for (const worker of workers) { @@ -234,36 +235,36 @@ function masterProcessMain() { clusterSettings.inspectPort = 'string'; cluster.setupMaster(clusterSettings); - assert.throws(() => { + common.expectsError(() => { cluster.fork(params).on('exit', common.mustCall(checkExitCode)); - }, TypeError); + }, badPortError); return; } else if (clusterSettings.inspectPort === 'null') { clusterSettings.inspectPort = null; cluster.setupMaster(clusterSettings); - assert.throws(() => { + common.expectsError(() => { cluster.fork(params).on('exit', common.mustCall(checkExitCode)); - }, TypeError); + }, badPortError); return; } else if (clusterSettings.inspectPort === 'bignumber') { clusterSettings.inspectPort = 1293812; cluster.setupMaster(clusterSettings); - assert.throws(() => { + common.expectsError(() => { cluster.fork(params).on('exit', common.mustCall(checkExitCode)); - }, TypeError); + }, badPortError); return; } else if (clusterSettings.inspectPort === 'negativenumber') { clusterSettings.inspectPort = -9776; cluster.setupMaster(clusterSettings); - assert.throws(() => { + common.expectsError(() => { cluster.fork(params).on('exit', common.mustCall(checkExitCode)); - }, TypeError); + }, badPortError); return; } else if (clusterSettings.inspectPort === 'bignumberfunc') { @@ -274,9 +275,9 @@ function masterProcessMain() { cluster.setupMaster(clusterSettings); - assert.throws(() => { + common.expectsError(() => { cluster.fork(params).on('exit', common.mustCall(checkExitCode)); - }, TypeError); + }, badPortError); return; } else if (clusterSettings.inspectPort === 'strfunc') { @@ -287,9 +288,9 @@ function masterProcessMain() { cluster.setupMaster(clusterSettings); - assert.throws(() => { + common.expectsError(() => { cluster.fork(params).on('exit', common.mustCall(checkExitCode)); - }, TypeError); + }, badPortError); return; } |