diff options
| author | Joyee Cheung <joyeec9h3@gmail.com> | 2019-04-19 23:12:28 +0800 |
|---|---|---|
| committer | Joyee Cheung <joyeec9h3@gmail.com> | 2019-04-22 19:09:52 +0800 |
| commit | 94adfe983194ce986774383d1b6832812f3446c7 (patch) | |
| tree | 7c71e651cfbfb26fac47818cc1a9c4a595d38ab4 /test/report | |
| parent | 19e3e02a2db996a3df36e00df6c6b57cec516c9e (diff) | |
| download | android-node-v8-94adfe983194ce986774383d1b6832812f3446c7.tar.gz android-node-v8-94adfe983194ce986774383d1b6832812f3446c7.tar.bz2 android-node-v8-94adfe983194ce986774383d1b6832812f3446c7.zip | |
lib: replace --diagnostic-report-* with --report-*
In the code base the word `report` is almost only used to refer to
the diagnostic report when it's a noun, and it's programmable
interface `process.report()` it not prefixed, so `report` should be
unambiguous enough to use without `diagnostic`.
PR-URL: https://github.com/nodejs/node/pull/27312
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Diffstat (limited to 'test/report')
| -rw-r--r-- | test/report/test-report-config.js | 2 | ||||
| -rw-r--r-- | test/report/test-report-fatal-error.js | 2 | ||||
| -rw-r--r-- | test/report/test-report-signal.js | 2 | ||||
| -rw-r--r-- | test/report/test-report-uncaught-exception.js | 2 | ||||
| -rw-r--r-- | test/report/test-report-writereport.js | 2 |
5 files changed, 5 insertions, 5 deletions
diff --git a/test/report/test-report-config.js b/test/report/test-report-config.js index 6d33851416..b8cfd02992 100644 --- a/test/report/test-report-config.js +++ b/test/report/test-report-config.js @@ -1,4 +1,4 @@ -// Flags: --experimental-report --diagnostic-report-on-fatalerror --diagnostic-report-on-signal --diagnostic-report-uncaught-exception +// Flags: --experimental-report --report-on-fatalerror --report-on-signal --report-uncaught-exception 'use strict'; const common = require('../common'); common.skipIfReportDisabled(); diff --git a/test/report/test-report-fatal-error.js b/test/report/test-report-fatal-error.js index b6cf792725..8ecd058cf8 100644 --- a/test/report/test-report-fatal-error.js +++ b/test/report/test-report-fatal-error.js @@ -23,7 +23,7 @@ if (process.argv[2] === 'child') { tmpdir.refresh(); const spawn = require('child_process').spawn; const args = ['--experimental-report', - '--diagnostic-report-on-fatalerror', + '--report-on-fatalerror', '--max-old-space-size=20', __filename, 'child']; diff --git a/test/report/test-report-signal.js b/test/report/test-report-signal.js index a71530a520..51244fcade 100644 --- a/test/report/test-report-signal.js +++ b/test/report/test-report-signal.js @@ -1,4 +1,4 @@ -// Flags: --experimental-report --diagnostic-report-on-signal +// Flags: --experimental-report --report-on-signal 'use strict'; // Test producing a report via signal. const common = require('../common'); diff --git a/test/report/test-report-uncaught-exception.js b/test/report/test-report-uncaught-exception.js index 34e4759ea2..4a2627c13c 100644 --- a/test/report/test-report-uncaught-exception.js +++ b/test/report/test-report-uncaught-exception.js @@ -1,4 +1,4 @@ -// Flags: --experimental-report --diagnostic-report-uncaught-exception +// Flags: --experimental-report --report-uncaught-exception 'use strict'; // Test producing a report on uncaught exception. const common = require('../common'); diff --git a/test/report/test-report-writereport.js b/test/report/test-report-writereport.js index 6c7ed8a71c..8a22600acf 100644 --- a/test/report/test-report-writereport.js +++ b/test/report/test-report-writereport.js @@ -111,7 +111,7 @@ function validate() { // Test the case where the report file cannot be opened. const reportDir = path.join(tmpdir.path, 'does', 'not', 'exist'); const args = ['--experimental-report', - `--diagnostic-report-directory=${reportDir}`, + `--report-directory=${reportDir}`, '-e', 'process.report.writeReport()']; const child = spawnSync(process.execPath, args, { cwd: tmpdir.path }); |