summaryrefslogtreecommitdiff
path: root/test/pummel
diff options
context:
space:
mode:
authorSam Roberts <vieuxtech@gmail.com>2019-01-15 12:49:45 -0800
committerSam Roberts <vieuxtech@gmail.com>2019-02-06 15:18:11 -0800
commitbca2e219a36372d94fe420d314ca3b2ad896f67b (patch)
treec313aa96c7ea712e1360cd82e20f61d077263e42 /test/pummel
parent1316b7652a50da7e996897edfab9a1d3c365d3b5 (diff)
downloadandroid-node-v8-bca2e219a36372d94fe420d314ca3b2ad896f67b.tar.gz
android-node-v8-bca2e219a36372d94fe420d314ca3b2ad896f67b.tar.bz2
android-node-v8-bca2e219a36372d94fe420d314ca3b2ad896f67b.zip
test: pin regression test for #8074 to TLS 1.2
This test has a dependency on the order in which the TCP connection is made, and TLS server handshake completes. It assumes those server side events occur before the client side write callback, which is not guaranteed by the TLS API. It usually passes with TLS1.3, but TLS1.3 didn't exist at the time the bug existed. Pin the test to TLS1.2, since the test shouldn't be changed in a way that doesn't trigger a segfault in 7.7.3: - https://github.com/nodejs/node/issues/13184#issuecomment-303700377 PR-URL: https://github.com/nodejs/node/pull/25508 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'test/pummel')
0 files changed, 0 insertions, 0 deletions