diff options
author | Sohail Rajdev <sohailrajdev97@gmail.com> | 2018-07-04 23:10:03 +0530 |
---|---|---|
committer | Trivikram Kamat <16024985+trivikr@users.noreply.github.com> | 2018-07-10 02:00:31 +0100 |
commit | b70db336707451bfe178ac6162279bb46d4a3e91 (patch) | |
tree | 4148e5b0bf341e75b8f4843869e3d6e263c2624b /test/pummel/test-timers.js | |
parent | e56fec07225dab2669e3345dcf783a18ca03ed43 (diff) | |
download | android-node-v8-b70db336707451bfe178ac6162279bb46d4a3e91.tar.gz android-node-v8-b70db336707451bfe178ac6162279bb46d4a3e91.tar.bz2 android-node-v8-b70db336707451bfe178ac6162279bb46d4a3e91.zip |
test: swap arguments in strictEqual()
This commit also comments the third argument
PR-URL: https://github.com/nodejs/node/pull/21660
Reviewed-By: Michaƫl Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Diffstat (limited to 'test/pummel/test-timers.js')
-rw-r--r-- | test/pummel/test-timers.js | 29 |
1 files changed, 15 insertions, 14 deletions
diff --git a/test/pummel/test-timers.js b/test/pummel/test-timers.js index 7e0492a642..a6766b7a33 100644 --- a/test/pummel/test-timers.js +++ b/test/pummel/test-timers.js @@ -31,7 +31,7 @@ let interval_count = 0; clearTimeout(null); clearInterval(null); -assert.strictEqual(true, setTimeout instanceof Function); +assert.strictEqual(setTimeout instanceof Function, true); const starttime = new Date(); setTimeout(common.mustCall(function() { const endtime = new Date(); @@ -40,7 +40,7 @@ setTimeout(common.mustCall(function() { assert.ok(diff > 0); console.error(`diff: ${diff}`); - assert.strictEqual(true, 1000 - WINDOW < diff && diff < 1000 + WINDOW); + assert.strictEqual(1000 - WINDOW < diff && diff < 1000 + WINDOW, true); }), 1000); // this timer shouldn't execute @@ -57,9 +57,9 @@ setInterval(function() { const t = interval_count * 1000; - assert.strictEqual(true, t - WINDOW < diff && diff < t + WINDOW); + assert.strictEqual(t - WINDOW < diff && diff < t + WINDOW, true); - assert.strictEqual(true, interval_count <= 3); + assert.strictEqual(interval_count <= 3, true); if (interval_count === 3) clearInterval(this); }, 1000); @@ -67,13 +67,13 @@ setInterval(function() { // Single param: setTimeout(function(param) { - assert.strictEqual('test param', param); + assert.strictEqual(param, 'test param'); }, 1000, 'test param'); let interval_count2 = 0; setInterval(function(param) { ++interval_count2; - assert.strictEqual('test param', param); + assert.strictEqual(param, 'test param'); if (interval_count2 === 3) clearInterval(this); @@ -82,15 +82,15 @@ setInterval(function(param) { // Multiple param setTimeout(function(param1, param2) { - assert.strictEqual('param1', param1); - assert.strictEqual('param2', param2); + assert.strictEqual(param1, 'param1'); + assert.strictEqual(param2, 'param2'); }, 1000, 'param1', 'param2'); let interval_count3 = 0; setInterval(function(param1, param2) { ++interval_count3; - assert.strictEqual('param1', param1); - assert.strictEqual('param2', param2); + assert.strictEqual(param1, 'param1'); + assert.strictEqual(param2, 'param2'); if (interval_count3 === 3) clearInterval(this); @@ -120,8 +120,9 @@ clearTimeout(y); process.on('exit', function() { - assert.strictEqual(3, interval_count); - assert.strictEqual(11, count4); - assert.strictEqual(0, expectedTimeouts, - 'clearTimeout cleared too many timeouts'); + assert.strictEqual(interval_count, 3); + assert.strictEqual(count4, 11); + + // Check that the correct number of timers ran. + assert.strictEqual(expectedTimeouts, 0); }); |