diff options
| author | Richard Lau <riclau@uk.ibm.com> | 2019-04-02 08:04:16 -0400 |
|---|---|---|
| committer | Richard Lau <riclau@uk.ibm.com> | 2019-04-16 04:35:11 -0400 |
| commit | f85ef977e6e9f0f655a8ff6aa4796d80ae94010e (patch) | |
| tree | 8874cd448ad90dc68e2af73a71114f417b70fcd4 /test/pummel/test-fs-readfile-tostring-fail.js | |
| parent | 53e0f632dbed27f0889322bcf0244c886c549835 (diff) | |
| download | android-node-v8-f85ef977e6e9f0f655a8ff6aa4796d80ae94010e.tar.gz android-node-v8-f85ef977e6e9f0f655a8ff6aa4796d80ae94010e.tar.bz2 android-node-v8-f85ef977e6e9f0f655a8ff6aa4796d80ae94010e.zip | |
test: log errors in test-fs-readfile-tostring-fail
The test writes out a large file via `fs.createWriteStream()` but was
not listening for the `error` event, which the `fs` docs describe as the
reliable way to detect write errors.
PR-URL: https://github.com/nodejs/node/pull/27058
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Diffstat (limited to 'test/pummel/test-fs-readfile-tostring-fail.js')
| -rw-r--r-- | test/pummel/test-fs-readfile-tostring-fail.js | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/test/pummel/test-fs-readfile-tostring-fail.js b/test/pummel/test-fs-readfile-tostring-fail.js index 9a443fc71b..a068b3af3b 100644 --- a/test/pummel/test-fs-readfile-tostring-fail.js +++ b/test/pummel/test-fs-readfile-tostring-fail.js @@ -21,6 +21,8 @@ const stream = fs.createWriteStream(file, { flags: 'a' }); +stream.on('error', (err) => { throw err; }); + const size = kStringMaxLength / 200; const a = Buffer.alloc(size, 'a'); |