summaryrefslogtreecommitdiff
path: root/test/pseudo-tty
diff options
context:
space:
mode:
authorJames M Snell <jasnell@gmail.com>2017-03-24 09:46:44 -0700
committerJames M Snell <jasnell@gmail.com>2017-03-26 12:47:15 -0700
commit4f2e372716714ed030cb5ba6e67107b913f15343 (patch)
tree9b86be4f904c7844c48cca4194f3c3a5a1decad8 /test/pseudo-tty
parentd13bd4acc0b60191f0d6e9fae92087242d04dfbd (diff)
downloadandroid-node-v8-4f2e372716714ed030cb5ba6e67107b913f15343.tar.gz
android-node-v8-4f2e372716714ed030cb5ba6e67107b913f15343.tar.bz2
android-node-v8-4f2e372716714ed030cb5ba6e67107b913f15343.zip
test: add common.noop, default for common.mustCall()
Export a new common.noop no-operation function for general use. Allow using common.mustCall() without a fn argument to simplify test cases. Replace various non-op functions throughout tests with common.noop PR-URL: https://github.com/nodejs/node/pull/12027 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Diffstat (limited to 'test/pseudo-tty')
-rw-r--r--test/pseudo-tty/ref_keeps_node_running.js5
1 files changed, 3 insertions, 2 deletions
diff --git a/test/pseudo-tty/ref_keeps_node_running.js b/test/pseudo-tty/ref_keeps_node_running.js
index de3c6531ef..7eb2d1a60a 100644
--- a/test/pseudo-tty/ref_keeps_node_running.js
+++ b/test/pseudo-tty/ref_keeps_node_running.js
@@ -1,5 +1,6 @@
'use strict';
-require('../common');
+
+const common = require('../common');
const { TTY, isTTY } = process.binding('tty_wrap');
const strictEqual = require('assert').strictEqual;
@@ -8,7 +9,7 @@ strictEqual(isTTY(0), true, 'fd 0 is not a TTY');
const handle = new TTY(0);
handle.readStart();
-handle.onread = () => {};
+handle.onread = common.noop;
function isHandleActive(handle) {
return process._getActiveHandles().some((active) => active === handle);