summaryrefslogtreecommitdiff
path: root/test/pseudo-tty/no_dropped_stdio.js
diff options
context:
space:
mode:
authorGireesh Punathil <gpunathi@in.ibm.com>2017-03-06 10:24:07 -0500
committerGibson Fahnestock <gibfahn@gmail.com>2017-03-17 12:28:44 +0000
commitd631af59c0c4bf0811c7176176bf78f68e9fab6d (patch)
treece36a9814536cd95d65299b7e4654a2b6ff23d82 /test/pseudo-tty/no_dropped_stdio.js
parentd099f8e317a6c55c2c0b877565b47d40c5a3ba9c (diff)
downloadandroid-node-v8-d631af59c0c4bf0811c7176176bf78f68e9fab6d.tar.gz
android-node-v8-d631af59c0c4bf0811c7176176bf78f68e9fab6d.tar.bz2
android-node-v8-d631af59c0c4bf0811c7176176bf78f68e9fab6d.zip
test: delay child exit in AIX for pseudo-tty tests
The tests in pseudo-tty takes the form of child node writing some data and exiting, while parent python consume them through pseudo tty implementations, and validate the result. While there is no synchronization between child and parent, this works for most platforms, except AIX, where the child exits even before the parent could setup the read loop, under race conditions Fixing the race condition is ideally done through sending ACK messages to and forth, but involves massive changes and have side effect. The workaround is to address them in AIX alone, by adding a reasonable delay. PR-URL: https://github.com/nodejs/node/pull/11715 Fixes: https://github.com/nodejs/node/issues/7973 Fixes: https://github.com/nodejs/node/issues/9765 Fixes: https://github.com/nodejs/node/issues/11541 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Diffstat (limited to 'test/pseudo-tty/no_dropped_stdio.js')
-rw-r--r--test/pseudo-tty/no_dropped_stdio.js10
1 files changed, 7 insertions, 3 deletions
diff --git a/test/pseudo-tty/no_dropped_stdio.js b/test/pseudo-tty/no_dropped_stdio.js
index b24d234a38..f7d9625c62 100644
--- a/test/pseudo-tty/no_dropped_stdio.js
+++ b/test/pseudo-tty/no_dropped_stdio.js
@@ -1,7 +1,7 @@
// https://github.com/nodejs/node/issues/6456#issuecomment-219320599
// https://gist.github.com/isaacs/1495b91ec66b21d30b10572d72ad2cdd
'use strict';
-require('../common');
+const common = require('../common');
// 1000 bytes wrapped at 50 columns
// \n turns into a double-byte character
@@ -11,5 +11,9 @@ let out = ('o'.repeat(48) + '\n').repeat(20);
// This results in 1025 bytes, just enough to overflow the 1kb OS X TTY buffer.
out += 'o'.repeat(24) + 'O';
-process.stdout.write(out);
-process.exit(0);
+// In AIX, the child exits even before the python parent
+// can setup the readloop. Provide a reasonable delay.
+setTimeout(function() {
+ process.stdout.write(out);
+ process.exit(0);
+}, common.isAix ? 200 : 0);