summaryrefslogtreecommitdiff
path: root/test/parallel
diff options
context:
space:
mode:
authorDany Shaanan <danyshaanan@gmail.com>2016-09-17 12:32:33 +0200
committerJames M Snell <jasnell@gmail.com>2016-09-20 16:35:39 -0700
commitd469321946690f95670663e0bb3ad5aa08c6bfda (patch)
treee348ec360438efcb7acf693844b55673a4482008 /test/parallel
parent66dbd9c9c1556b3ecd3c9f0ce13de99e4d2fc7e5 (diff)
downloadandroid-node-v8-d469321946690f95670663e0bb3ad5aa08c6bfda.tar.gz
android-node-v8-d469321946690f95670663e0bb3ad5aa08c6bfda.tar.bz2
android-node-v8-d469321946690f95670663e0bb3ad5aa08c6bfda.zip
tools: add eslint rule prefer-assert-methods
PR-URL: https://github.com/nodejs/node/pull/8622 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com> Reviewed-By: Jackson Tian <shvyo1987@gmail.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
Diffstat (limited to 'test/parallel')
-rw-r--r--test/parallel/test-child-process-detached.js1
-rw-r--r--test/parallel/test-child-process-fork-regr-gh-2847.js2
-rw-r--r--test/parallel/test-cluster-setup-master-argv.js2
-rw-r--r--test/parallel/test-domain-http-server.js2
-rw-r--r--test/parallel/test-domain-top-level-error-handler-throw.js7
-rw-r--r--test/parallel/test-event-emitter-listeners-side-effects.js20
-rw-r--r--test/parallel/test-file-write-stream2.js2
-rw-r--r--test/parallel/test-fs-access.js8
-rw-r--r--test/parallel/test-fs-mkdtemp.js2
-rw-r--r--test/parallel/test-fs-readfile-pipe-large.js4
-rw-r--r--test/parallel/test-fs-readfile-pipe.js4
-rw-r--r--test/parallel/test-fs-readfile-unlink.js2
-rw-r--r--test/parallel/test-fs-readfilesync-pipe-large.js4
-rw-r--r--test/parallel/test-fs-stat.js8
-rw-r--r--test/parallel/test-fs-write-stream-autoclose-option.js2
-rw-r--r--test/parallel/test-http-agent-destroyed-socket.js6
-rw-r--r--test/parallel/test-http-byteswritten.js2
-rw-r--r--test/parallel/test-http-client-default-headers-exist.js14
-rw-r--r--test/parallel/test-http-methods.js6
-rw-r--r--test/parallel/test-http-write-head.js2
-rw-r--r--test/parallel/test-https-byteswritten.js2
-rw-r--r--test/parallel/test-internal-modules.js5
-rw-r--r--test/parallel/test-process-config.js2
-rw-r--r--test/parallel/test-process-getgroups.js2
-rw-r--r--test/parallel/test-repl-context.js2
-rw-r--r--test/parallel/test-require-json.js2
-rw-r--r--test/parallel/test-stream-duplex.js4
-rw-r--r--test/parallel/test-stream-transform-split-objectmode.js12
-rw-r--r--test/parallel/test-stream2-writable.js2
-rw-r--r--test/parallel/test-timers-active.js2
-rw-r--r--test/parallel/test-tls-alert-handling.js2
-rw-r--r--test/parallel/test-tls-pfx-gh-5100-regr.js6
-rw-r--r--test/parallel/test-tls-server-connection-server.js2
-rw-r--r--test/parallel/test-url.js4
-rw-r--r--test/parallel/test-vm-harmony-symbols.js8
-rw-r--r--test/parallel/test-vm-proxies.js8
36 files changed, 90 insertions, 75 deletions
diff --git a/test/parallel/test-child-process-detached.js b/test/parallel/test-child-process-detached.js
index b4cb8f4136..d550401fae 100644
--- a/test/parallel/test-child-process-detached.js
+++ b/test/parallel/test-child-process-detached.js
@@ -23,4 +23,3 @@ process.on('exit', function() {
process.kill(persistentPid);
});
});
-
diff --git a/test/parallel/test-child-process-fork-regr-gh-2847.js b/test/parallel/test-child-process-fork-regr-gh-2847.js
index dba3325940..e7815db1b4 100644
--- a/test/parallel/test-child-process-fork-regr-gh-2847.js
+++ b/test/parallel/test-child-process-fork-regr-gh-2847.js
@@ -45,7 +45,7 @@ var server = net.createServer(function(s) {
worker.process.once('close', common.mustCall(function() {
// Otherwise the crash on `_channel.fd` access may happen
- assert(worker.process._channel === null);
+ assert.strictEqual(worker.process._channel, null);
server.close();
}));
diff --git a/test/parallel/test-cluster-setup-master-argv.js b/test/parallel/test-cluster-setup-master-argv.js
index e111ba9ffa..c42291417f 100644
--- a/test/parallel/test-cluster-setup-master-argv.js
+++ b/test/parallel/test-cluster-setup-master-argv.js
@@ -12,7 +12,7 @@ cluster.on('setup', function() {
realArgs[realArgs.length - 1]);
});
-assert(process.argv[process.argv.length - 1] !== 'OMG,OMG');
+assert.notStrictEqual(process.argv[process.argv.length - 1], 'OMG,OMG');
process.argv.push('OMG,OMG');
process.argv.push('OMG,OMG');
cluster.setupMaster();
diff --git a/test/parallel/test-domain-http-server.js b/test/parallel/test-domain-http-server.js
index e131e02ea4..e6e4b294cf 100644
--- a/test/parallel/test-domain-http-server.js
+++ b/test/parallel/test-domain-http-server.js
@@ -30,7 +30,7 @@ var server = http.createServer(function(req, res) {
var data = JSON.stringify(objects[req.url.replace(/[^a-z]/g, '')]);
// this line will throw if you pick an unknown key
- assert(data !== undefined, 'Data should not be undefined');
+ assert.notStrictEqual(data, undefined, 'Data should not be undefined');
res.writeHead(200);
res.end(data);
diff --git a/test/parallel/test-domain-top-level-error-handler-throw.js b/test/parallel/test-domain-top-level-error-handler-throw.js
index 7933c5d052..c98dfc3f1f 100644
--- a/test/parallel/test-domain-top-level-error-handler-throw.js
+++ b/test/parallel/test-domain-top-level-error-handler-throw.js
@@ -37,8 +37,11 @@ if (process.argv[2] === 'child') {
});
child.on('close', function onChildClosed() {
- assert(stderrOutput.indexOf(domainErrHandlerExMessage) !== -1);
- assert(stderrOutput.indexOf(internalExMessage) === -1);
+ assert.notStrictEqual(
+ stderrOutput.indexOf(domainErrHandlerExMessage),
+ -1
+ );
+ assert.strictEqual(stderrOutput.indexOf(internalExMessage), -1);
});
child.on('exit', function onChildExited(exitCode, signal) {
diff --git a/test/parallel/test-event-emitter-listeners-side-effects.js b/test/parallel/test-event-emitter-listeners-side-effects.js
index 1bed99f364..906138af23 100644
--- a/test/parallel/test-event-emitter-listeners-side-effects.js
+++ b/test/parallel/test-event-emitter-listeners-side-effects.js
@@ -10,16 +10,16 @@ var fl; // foo listeners
fl = e.listeners('foo');
assert(Array.isArray(fl));
-assert(fl.length === 0);
+assert.strictEqual(fl.length, 0);
assert(!(e._events instanceof Object));
assert.deepStrictEqual(Object.keys(e._events), []);
e.on('foo', common.fail);
fl = e.listeners('foo');
-assert(e._events.foo === common.fail);
+assert.strictEqual(e._events.foo, common.fail);
assert(Array.isArray(fl));
-assert(fl.length === 1);
-assert(fl[0] === common.fail);
+assert.strictEqual(fl.length, 1);
+assert.strictEqual(fl[0], common.fail);
e.listeners('bar');
@@ -27,13 +27,13 @@ e.on('foo', assert.ok);
fl = e.listeners('foo');
assert(Array.isArray(e._events.foo));
-assert(e._events.foo.length === 2);
-assert(e._events.foo[0] === common.fail);
-assert(e._events.foo[1] === assert.ok);
+assert.strictEqual(e._events.foo.length, 2);
+assert.strictEqual(e._events.foo[0], common.fail);
+assert.strictEqual(e._events.foo[1], assert.ok);
assert(Array.isArray(fl));
-assert(fl.length === 2);
-assert(fl[0] === common.fail);
-assert(fl[1] === assert.ok);
+assert.strictEqual(fl.length, 2);
+assert.strictEqual(fl[0], common.fail);
+assert.strictEqual(fl[1], assert.ok);
console.log('ok');
diff --git a/test/parallel/test-file-write-stream2.js b/test/parallel/test-file-write-stream2.js
index e11f7e7815..6f0ccedb07 100644
--- a/test/parallel/test-file-write-stream2.js
+++ b/test/parallel/test-file-write-stream2.js
@@ -85,6 +85,6 @@ for (var i = 0; i < 11; i++) {
console.error('%d %j', i, ret);
// return false when i hits 10
- assert(ret === (i != 10));
+ assert.strictEqual(ret, i != 10);
}
cb_occurred += 'write ';
diff --git a/test/parallel/test-fs-access.js b/test/parallel/test-fs-access.js
index 6b82b4bbf3..6da26fe47b 100644
--- a/test/parallel/test-fs-access.js
+++ b/test/parallel/test-fs-access.js
@@ -58,10 +58,10 @@ if (!common.isWindows && process.getuid() === 0) {
}
}
-assert(typeof fs.F_OK === 'number');
-assert(typeof fs.R_OK === 'number');
-assert(typeof fs.W_OK === 'number');
-assert(typeof fs.X_OK === 'number');
+assert.strictEqual(typeof fs.F_OK, 'number');
+assert.strictEqual(typeof fs.R_OK, 'number');
+assert.strictEqual(typeof fs.W_OK, 'number');
+assert.strictEqual(typeof fs.X_OK, 'number');
fs.access(__filename, function(err) {
assert.strictEqual(err, null, 'error should not exist');
diff --git a/test/parallel/test-fs-mkdtemp.js b/test/parallel/test-fs-mkdtemp.js
index dd4ab75c22..c387090989 100644
--- a/test/parallel/test-fs-mkdtemp.js
+++ b/test/parallel/test-fs-mkdtemp.js
@@ -10,7 +10,7 @@ common.refreshTmpDir();
const tmpFolder = fs.mkdtempSync(path.join(common.tmpDir, 'foo.'));
-assert(path.basename(tmpFolder).length === 'foo.XXXXXX'.length);
+assert.strictEqual(path.basename(tmpFolder).length, 'foo.XXXXXX'.length);
assert(common.fileExists(tmpFolder));
const utf8 = fs.mkdtempSync(path.join(common.tmpDir, '\u0222abc.'));
diff --git a/test/parallel/test-fs-readfile-pipe-large.js b/test/parallel/test-fs-readfile-pipe-large.js
index a39f66ef80..5ebdcb211c 100644
--- a/test/parallel/test-fs-readfile-pipe-large.js
+++ b/test/parallel/test-fs-readfile-pipe-large.js
@@ -32,8 +32,8 @@ var cmd = 'cat ' + filename + ' | ' + node + ' ' + f + ' child';
exec(cmd, { maxBuffer: 1000000 }, function(err, stdout, stderr) {
if (err) console.error(err);
assert(!err, 'it exits normally');
- assert(stdout === dataExpected, 'it reads the file and outputs it');
- assert(stderr === '', 'it does not write to stderr');
+ assert.strictEqual(stdout, dataExpected, 'it reads the file and outputs it');
+ assert.strictEqual(stderr, '', 'it does not write to stderr');
console.log('ok');
});
diff --git a/test/parallel/test-fs-readfile-pipe.js b/test/parallel/test-fs-readfile-pipe.js
index d4db43db6e..6542175a90 100644
--- a/test/parallel/test-fs-readfile-pipe.js
+++ b/test/parallel/test-fs-readfile-pipe.js
@@ -28,7 +28,7 @@ var cmd = 'cat ' + f + ' | ' + node + ' ' + f + ' child';
exec(cmd, function(err, stdout, stderr) {
if (err) console.error(err);
assert(!err, 'it exits normally');
- assert(stdout === dataExpected, 'it reads the file and outputs it');
- assert(stderr === '', 'it does not write to stderr');
+ assert.strictEqual(stdout, dataExpected, 'it reads the file and outputs it');
+ assert.strictEqual(stderr, '', 'it does not write to stderr');
console.log('ok');
});
diff --git a/test/parallel/test-fs-readfile-unlink.js b/test/parallel/test-fs-readfile-unlink.js
index e0539fa100..1be81b824c 100644
--- a/test/parallel/test-fs-readfile-unlink.js
+++ b/test/parallel/test-fs-readfile-unlink.js
@@ -19,7 +19,7 @@ fs.writeFileSync(fileName, buf);
fs.readFile(fileName, function(err, data) {
assert.ifError(err);
- assert(data.length == buf.length);
+ assert.equal(data.length, buf.length);
assert.strictEqual(buf[0], 42);
fs.unlinkSync(fileName);
diff --git a/test/parallel/test-fs-readfilesync-pipe-large.js b/test/parallel/test-fs-readfilesync-pipe-large.js
index ce667094d1..0aa33a110b 100644
--- a/test/parallel/test-fs-readfilesync-pipe-large.js
+++ b/test/parallel/test-fs-readfilesync-pipe-large.js
@@ -29,8 +29,8 @@ var cmd = 'cat ' + filename + ' | ' + node + ' ' + f + ' child';
exec(cmd, { maxBuffer: 1000000 }, function(err, stdout, stderr) {
if (err) console.error(err);
assert(!err, 'it exits normally');
- assert(stdout === dataExpected, 'it reads the file and outputs it');
- assert(stderr === '', 'it does not write to stderr');
+ assert.strictEqual(stdout, dataExpected, 'it reads the file and outputs it');
+ assert.strictEqual(stderr, '', 'it does not write to stderr');
console.log('ok');
});
diff --git a/test/parallel/test-fs-stat.js b/test/parallel/test-fs-stat.js
index ac68a9ae42..2c844452f0 100644
--- a/test/parallel/test-fs-stat.js
+++ b/test/parallel/test-fs-stat.js
@@ -6,7 +6,7 @@ var fs = require('fs');
fs.stat('.', common.mustCall(function(err, stats) {
assert.ifError(err);
assert.ok(stats.mtime instanceof Date);
- assert(this === global);
+ assert.strictEqual(this, global);
}));
fs.stat('.', common.mustCall(function(err, stats) {
@@ -17,7 +17,7 @@ fs.stat('.', common.mustCall(function(err, stats) {
fs.lstat('.', common.mustCall(function(err, stats) {
assert.ifError(err);
assert.ok(stats.mtime instanceof Date);
- assert(this === global);
+ assert.strictEqual(this, global);
}));
// fstat
@@ -29,10 +29,10 @@ fs.open('.', 'r', undefined, common.mustCall(function(err, fd) {
assert.ifError(err);
assert.ok(stats.mtime instanceof Date);
fs.close(fd);
- assert(this === global);
+ assert.strictEqual(this, global);
}));
- assert(this === global);
+ assert.strictEqual(this, global);
}));
// fstatSync
diff --git a/test/parallel/test-fs-write-stream-autoclose-option.js b/test/parallel/test-fs-write-stream-autoclose-option.js
index 0706ed6485..c7d21db2b4 100644
--- a/test/parallel/test-fs-write-stream-autoclose-option.js
+++ b/test/parallel/test-fs-write-stream-autoclose-option.js
@@ -12,7 +12,7 @@ stream.end();
stream.on('finish', common.mustCall(function() {
process.nextTick(common.mustCall(function() {
assert.strictEqual(stream.closed, undefined);
- assert(stream.fd !== null);
+ assert.notStrictEqual(stream.fd, null);
next();
}));
}));
diff --git a/test/parallel/test-http-agent-destroyed-socket.js b/test/parallel/test-http-agent-destroyed-socket.js
index 34772f7d3e..a269363772 100644
--- a/test/parallel/test-http-agent-destroyed-socket.js
+++ b/test/parallel/test-http-agent-destroyed-socket.js
@@ -23,7 +23,7 @@ var server = http.createServer(function(req, res) {
var request1 = http.get(requestOptions, function(response) {
// assert request2 is queued in the agent
var key = agent.getName(requestOptions);
- assert(agent.requests[key].length === 1);
+ assert.strictEqual(agent.requests[key].length, 1);
console.log('got response1');
request1.socket.on('close', function() {
console.log('request1 socket closed');
@@ -51,7 +51,7 @@ var server = http.createServer(function(req, res) {
process.nextTick(function() {
// assert that the same socket was not assigned to request2,
// since it was destroyed.
- assert(request1.socket !== request2.socket);
+ assert.notStrictEqual(request1.socket, request2.socket);
assert(!request2.socket.destroyed, 'the socket is destroyed');
});
});
@@ -62,7 +62,7 @@ var server = http.createServer(function(req, res) {
assert(!request2.socket.destroyed);
assert(request1.socket.destroyed);
// assert not reusing the same socket, since it was destroyed.
- assert(request1.socket !== request2.socket);
+ assert.notStrictEqual(request1.socket, request2.socket);
console.log('got response2');
var gotClose = false;
var gotResponseEnd = false;
diff --git a/test/parallel/test-http-byteswritten.js b/test/parallel/test-http-byteswritten.js
index 27ca84b166..bb914439a7 100644
--- a/test/parallel/test-http-byteswritten.js
+++ b/test/parallel/test-http-byteswritten.js
@@ -9,7 +9,7 @@ var httpServer = http.createServer(common.mustCall(function(req, res) {
httpServer.close();
res.on('finish', common.mustCall(function() {
- assert(typeof req.connection.bytesWritten === 'number');
+ assert.strictEqual(typeof req.connection.bytesWritten, 'number');
assert(req.connection.bytesWritten > 0);
}));
res.writeHead(200, { 'Content-Type': 'text/plain' });
diff --git a/test/parallel/test-http-client-default-headers-exist.js b/test/parallel/test-http-client-default-headers-exist.js
index ec96002399..9b73f2db32 100644
--- a/test/parallel/test-http-client-default-headers-exist.js
+++ b/test/parallel/test-http-client-default-headers-exist.js
@@ -25,12 +25,18 @@ var server = http.createServer(function(req, res) {
var requestHeaders = Object.keys(req.headers);
requestHeaders.forEach(function(header) {
- assert(expectedHeaders[req.method].indexOf(header.toLowerCase()) !== -1,
- header + ' shoud not exist for method ' + req.method);
+ assert.notStrictEqual(
+ expectedHeaders[req.method].indexOf(header.toLowerCase()),
+ -1,
+ header + ' shoud not exist for method ' + req.method
+ );
});
- assert(requestHeaders.length === expectedHeaders[req.method].length,
- 'some headers were missing for method: ' + req.method);
+ assert.strictEqual(
+ requestHeaders.length,
+ expectedHeaders[req.method].length,
+ 'some headers were missing for method: ' + req.method
+ );
if (expectedMethods.length === requestCount)
server.close();
diff --git a/test/parallel/test-http-methods.js b/test/parallel/test-http-methods.js
index 7babb714a4..d3d4fedd46 100644
--- a/test/parallel/test-http-methods.js
+++ b/test/parallel/test-http-methods.js
@@ -6,7 +6,7 @@ var util = require('util');
assert(Array.isArray(http.METHODS));
assert(http.METHODS.length > 0);
-assert(http.METHODS.indexOf('GET') !== -1);
-assert(http.METHODS.indexOf('HEAD') !== -1);
-assert(http.METHODS.indexOf('POST') !== -1);
+assert.notStrictEqual(http.METHODS.indexOf('GET'), -1);
+assert.notStrictEqual(http.METHODS.indexOf('HEAD'), -1);
+assert.notStrictEqual(http.METHODS.indexOf('POST'), -1);
assert.deepStrictEqual(util._extend([], http.METHODS), http.METHODS.sort());
diff --git a/test/parallel/test-http-write-head.js b/test/parallel/test-http-write-head.js
index e55ae14eb6..32fff6042e 100644
--- a/test/parallel/test-http-write-head.js
+++ b/test/parallel/test-http-write-head.js
@@ -40,7 +40,7 @@ function runTest() {
http.get({ port: this.address().port }, function(response) {
response.on('end', function() {
assert.equal(response.headers['test'], '2');
- assert(response.rawHeaders.indexOf('Test') !== -1);
+ assert.notStrictEqual(response.rawHeaders.indexOf('Test'), -1);
s.close();
});
response.resume();
diff --git a/test/parallel/test-https-byteswritten.js b/test/parallel/test-https-byteswritten.js
index 0ca4bca95c..58dfb12dbe 100644
--- a/test/parallel/test-https-byteswritten.js
+++ b/test/parallel/test-https-byteswritten.js
@@ -18,7 +18,7 @@ var body = 'hello world\n';
var httpsServer = https.createServer(options, function(req, res) {
res.on('finish', function() {
- assert(typeof req.connection.bytesWritten === 'number');
+ assert.strictEqual(typeof req.connection.bytesWritten, 'number');
assert(req.connection.bytesWritten > 0);
httpsServer.close();
console.log('ok');
diff --git a/test/parallel/test-internal-modules.js b/test/parallel/test-internal-modules.js
index 5880801ce2..ea300d5c5f 100644
--- a/test/parallel/test-internal-modules.js
+++ b/test/parallel/test-internal-modules.js
@@ -7,4 +7,7 @@ assert.throws(function() {
require('internal/freelist');
});
-assert(require(path.join(common.fixturesDir, 'internal-modules')) === 42);
+assert.strictEqual(
+ require(path.join(common.fixturesDir, 'internal-modules')),
+ 42
+);
diff --git a/test/parallel/test-process-config.js b/test/parallel/test-process-config.js
index 538a067f58..ab38a48e5a 100644
--- a/test/parallel/test-process-config.js
+++ b/test/parallel/test-process-config.js
@@ -8,7 +8,7 @@ var path = require('path');
assert(process.hasOwnProperty('config'));
// ensure that `process.config` is an Object
-assert(Object(process.config) === process.config);
+assert.strictEqual(Object(process.config), process.config);
var configPath = path.resolve(__dirname, '..', '..', 'config.gypi');
var config = fs.readFileSync(configPath, 'utf8');
diff --git a/test/parallel/test-process-getgroups.js b/test/parallel/test-process-getgroups.js
index 7910eb3e29..002ec7c1ab 100644
--- a/test/parallel/test-process-getgroups.js
+++ b/test/parallel/test-process-getgroups.js
@@ -22,5 +22,5 @@ if (typeof process.getgroups === 'function') {
}
function check(a, b) {
- for (var i = 0; i < a.length; ++i) assert(b.indexOf(a[i]) !== -1);
+ for (var i = 0; i < a.length; ++i) assert.notStrictEqual(b.indexOf(a[i]), -1);
}
diff --git a/test/parallel/test-repl-context.js b/test/parallel/test-repl-context.js
index 1b319a036f..2287a247d8 100644
--- a/test/parallel/test-repl-context.js
+++ b/test/parallel/test-repl-context.js
@@ -19,7 +19,7 @@ function testContext(repl) {
assert(context.console instanceof require('console').Console);
// ensure that the repl's global property is the context
- assert(context.global === context);
+ assert.strictEqual(context.global, context);
// ensure that the repl console instance does not have a setter
assert.throws(() => context.console = 'foo');
diff --git a/test/parallel/test-require-json.js b/test/parallel/test-require-json.js
index ac70381c05..be9f5f0aaa 100644
--- a/test/parallel/test-require-json.js
+++ b/test/parallel/test-require-json.js
@@ -8,5 +8,5 @@ try {
} catch (err) {
var re = /test[\/\\]fixtures[\/\\]invalid.json: Unexpected string/;
var i = err.message.match(re);
- assert(null !== i, 'require() json error should include path');
+ assert.notStrictEqual(null, i, 'require() json error should include path');
}
diff --git a/test/parallel/test-stream-duplex.js b/test/parallel/test-stream-duplex.js
index 200de24877..a59eeb1a2a 100644
--- a/test/parallel/test-stream-duplex.js
+++ b/test/parallel/test-stream-duplex.js
@@ -27,6 +27,6 @@ stream.push({ val: 1 });
stream.end({ val: 2 });
process.on('exit', function() {
- assert(read.val === 1);
- assert(written.val === 2);
+ assert.strictEqual(read.val, 1);
+ assert.strictEqual(written.val, 2);
});
diff --git a/test/parallel/test-stream-transform-split-objectmode.js b/test/parallel/test-stream-transform-split-objectmode.js
index 9db2fa51d8..610f234bea 100644
--- a/test/parallel/test-stream-transform-split-objectmode.js
+++ b/test/parallel/test-stream-transform-split-objectmode.js
@@ -8,8 +8,8 @@ var parser = new Transform({ readableObjectMode: true });
assert(parser._readableState.objectMode);
assert(!parser._writableState.objectMode);
-assert(parser._readableState.highWaterMark === 16);
-assert(parser._writableState.highWaterMark === (16 * 1024));
+assert.strictEqual(parser._readableState.highWaterMark, 16);
+assert.strictEqual(parser._writableState.highWaterMark, 16 * 1024);
parser._transform = function(chunk, enc, callback) {
callback(null, { val: chunk[0] });
@@ -24,7 +24,7 @@ parser.on('data', function(obj) {
parser.end(Buffer.from([42]));
process.on('exit', function() {
- assert(parsed.val === 42);
+ assert.strictEqual(parsed.val, 42);
});
@@ -32,8 +32,8 @@ var serializer = new Transform({ writableObjectMode: true });
assert(!serializer._readableState.objectMode);
assert(serializer._writableState.objectMode);
-assert(serializer._readableState.highWaterMark === (16 * 1024));
-assert(serializer._writableState.highWaterMark === 16);
+assert.strictEqual(serializer._readableState.highWaterMark, 16 * 1024);
+assert.strictEqual(serializer._writableState.highWaterMark, 16);
serializer._transform = function(obj, _, callback) {
callback(null, Buffer.from([obj.val]));
@@ -48,5 +48,5 @@ serializer.on('data', function(chunk) {
serializer.write({ val: 42 });
process.on('exit', function() {
- assert(serialized[0] === 42);
+ assert.strictEqual(serialized[0], 42);
});
diff --git a/test/parallel/test-stream2-writable.js b/test/parallel/test-stream2-writable.js
index a9d526f8c0..57877b048b 100644
--- a/test/parallel/test-stream2-writable.js
+++ b/test/parallel/test-stream2-writable.js
@@ -168,7 +168,7 @@ test('write no bufferize', function(t) {
});
tw._write = function(chunk, encoding, cb) {
- assert(typeof chunk === 'string');
+ assert.strictEqual(typeof chunk, 'string');
chunk = Buffer.from(chunk, encoding);
return TestWriter.prototype._write.call(this, chunk, encoding, cb);
};
diff --git a/test/parallel/test-timers-active.js b/test/parallel/test-timers-active.js
index d8faa1f5a3..8677e43971 100644
--- a/test/parallel/test-timers-active.js
+++ b/test/parallel/test-timers-active.js
@@ -13,7 +13,7 @@ legitTimers.forEach(function(legit) {
const savedTimeout = legit._idleTimeout;
active(legit);
// active() should mutate these objects
- assert(legit._idleTimeout === savedTimeout);
+ assert.strictEqual(legit._idleTimeout, savedTimeout);
assert(Number.isInteger(legit._idleStart));
assert(legit._idleNext);
assert(legit._idlePrev);
diff --git a/test/parallel/test-tls-alert-handling.js b/test/parallel/test-tls-alert-handling.js
index 3f3ddd1955..284a32ea0d 100644
--- a/test/parallel/test-tls-alert-handling.js
+++ b/test/parallel/test-tls-alert-handling.js
@@ -86,6 +86,6 @@ function sendBADTLSRecord() {
}
process.on('exit', function() {
- assert(iter === max_iter);
+ assert.strictEqual(iter, max_iter);
assert(success);
});
diff --git a/test/parallel/test-tls-pfx-gh-5100-regr.js b/test/parallel/test-tls-pfx-gh-5100-regr.js
index 385c09208e..4670d9ea3d 100644
--- a/test/parallel/test-tls-pfx-gh-5100-regr.js
+++ b/test/parallel/test-tls-pfx-gh-5100-regr.js
@@ -21,7 +21,11 @@ const server = tls.createServer({
requestCert: true,
rejectUnauthorized: false
}, common.mustCall(function(c) {
- assert(c.authorizationError === null, 'authorizationError must be null');
+ assert.strictEqual(
+ c.authorizationError,
+ null,
+ 'authorizationError must be null'
+ );
c.end();
})).listen(0, function() {
var client = tls.connect({
diff --git a/test/parallel/test-tls-server-connection-server.js b/test/parallel/test-tls-server-connection-server.js
index ee4bcbebfd..e33c80be07 100644
--- a/test/parallel/test-tls-server-connection-server.js
+++ b/test/parallel/test-tls-server-connection-server.js
@@ -24,7 +24,7 @@ const server = tls.createServer(options, function(s) {
};
server.on('connection', common.mustCall(function(socket) {
- assert(socket.server === server);
+ assert.strictEqual(socket.server, server);
server.close();
}));
diff --git a/test/parallel/test-url.js b/test/parallel/test-url.js
index b9f1e7b62f..5530d285c8 100644
--- a/test/parallel/test-url.js
+++ b/test/parallel/test-url.js
@@ -1663,5 +1663,5 @@ var throws = [
for (let i = 0; i < throws.length; i++) {
assert.throws(function() { url.format(throws[i]); }, TypeError);
}
-assert(url.format('') === '');
-assert(url.format({}) === '');
+assert.strictEqual(url.format(''), '');
+assert.strictEqual(url.format({}), '');
diff --git a/test/parallel/test-vm-harmony-symbols.js b/test/parallel/test-vm-harmony-symbols.js
index 456a28f4d5..1c1274ef35 100644
--- a/test/parallel/test-vm-harmony-symbols.js
+++ b/test/parallel/test-vm-harmony-symbols.js
@@ -6,11 +6,11 @@ var vm = require('vm');
// The sandbox should have its own Symbol constructor.
var sandbox = {};
vm.runInNewContext('this.Symbol = Symbol', sandbox);
-assert(typeof sandbox.Symbol === 'function');
-assert(sandbox.Symbol !== Symbol);
+assert.strictEqual(typeof sandbox.Symbol, 'function');
+assert.notStrictEqual(sandbox.Symbol, Symbol);
// Unless we copy the Symbol constructor explicitly, of course.
sandbox = { Symbol: Symbol };
vm.runInNewContext('this.Symbol = Symbol', sandbox);
-assert(typeof sandbox.Symbol === 'function');
-assert(sandbox.Symbol === Symbol);
+assert.strictEqual(typeof sandbox.Symbol, 'function');
+assert.strictEqual(sandbox.Symbol, Symbol);
diff --git a/test/parallel/test-vm-proxies.js b/test/parallel/test-vm-proxies.js
index d789293e1c..d47f750821 100644
--- a/test/parallel/test-vm-proxies.js
+++ b/test/parallel/test-vm-proxies.js
@@ -8,11 +8,11 @@ var vm = require('vm');
// context. Make sure that the new context has a Proxy object of its own.
var sandbox = {};
vm.runInNewContext('this.Proxy = Proxy', sandbox);
-assert(typeof sandbox.Proxy === 'function');
-assert(sandbox.Proxy !== Proxy);
+assert.strictEqual(typeof sandbox.Proxy, 'function');
+assert.notStrictEqual(sandbox.Proxy, Proxy);
// Unless we copy the Proxy object explicitly, of course.
sandbox = { Proxy: Proxy };
vm.runInNewContext('this.Proxy = Proxy', sandbox);
-assert(typeof sandbox.Proxy === 'function');
-assert(sandbox.Proxy === Proxy);
+assert.strictEqual(typeof sandbox.Proxy, 'function');
+assert.strictEqual(sandbox.Proxy, Proxy);