diff options
author | Joyee Cheung <joyeec9h3@gmail.com> | 2019-03-13 22:43:00 +0800 |
---|---|---|
committer | Ruben Bridgewater <ruben@bridgewater.de> | 2019-04-25 01:29:48 +0200 |
commit | b9f1e572017c146da66077331260bac0e60c0928 (patch) | |
tree | 94813ea917a49cb573d141f225922534770e6eed /test/parallel | |
parent | 237d9f97165da39d1e540699294cf2dc83bbc2d3 (diff) | |
download | android-node-v8-b9f1e572017c146da66077331260bac0e60c0928.tar.gz android-node-v8-b9f1e572017c146da66077331260bac0e60c0928.tar.bz2 android-node-v8-b9f1e572017c146da66077331260bac0e60c0928.zip |
lib: throw a special error in internal/assert
Instead of using the public AssertionError, use a simplified
error that describes potential causes of these assertions
and suggests the user to open an issue.
PR-URL: https://github.com/nodejs/node/pull/26635
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Diffstat (limited to 'test/parallel')
-rw-r--r-- | test/parallel/test-internal-assert.js | 10 | ||||
-rw-r--r-- | test/parallel/test-internal-errors.js | 8 | ||||
-rw-r--r-- | test/parallel/test-tls-basic-validations.js | 7 |
3 files changed, 8 insertions, 17 deletions
diff --git a/test/parallel/test-internal-assert.js b/test/parallel/test-internal-assert.js index 4fd443864b..18528e9b27 100644 --- a/test/parallel/test-internal-assert.js +++ b/test/parallel/test-internal-assert.js @@ -1,17 +1,13 @@ // Flags: --expose-internals 'use strict'; +// This tests that the internal assert module works as expected. +// The failures are tested in test/message. + require('../common'); -const assert = require('assert'); const internalAssert = require('internal/assert'); // Should not throw. internalAssert(true); internalAssert(true, 'fhqwhgads'); - -assert.throws(() => { internalAssert(false); }, assert.AssertionError); -assert.throws(() => { internalAssert(false, 'fhqwhgads'); }, - { code: 'ERR_ASSERTION', message: 'fhqwhgads' }); -assert.throws(() => { internalAssert.fail('fhqwhgads'); }, - { code: 'ERR_ASSERTION', message: 'fhqwhgads' }); diff --git a/test/parallel/test-internal-errors.js b/test/parallel/test-internal-errors.js index 53fbf06c77..10d79cb8fa 100644 --- a/test/parallel/test-internal-errors.js +++ b/test/parallel/test-internal-errors.js @@ -50,12 +50,10 @@ errors.E('TEST_ERROR_2', (a, b) => `${a} ${b}`, Error); } { - assert.throws( + common.expectsInternalAssertion( () => new errors.codes.TEST_ERROR_1(), - { - message: 'Code: TEST_ERROR_1; The provided arguments ' + - 'length (0) does not match the required ones (1).' - } + 'Code: TEST_ERROR_1; The provided arguments ' + + 'length (0) does not match the required ones (1).' ); } diff --git a/test/parallel/test-tls-basic-validations.js b/test/parallel/test-tls-basic-validations.js index 9bcc63c454..925c6643a1 100644 --- a/test/parallel/test-tls-basic-validations.js +++ b/test/parallel/test-tls-basic-validations.js @@ -78,12 +78,9 @@ common.expectsError( assert.throws(() => tls.createServer({ ticketKeys: Buffer.alloc(0) }), /TypeError: Ticket keys length must be 48 bytes/); -common.expectsError( +common.expectsInternalAssertion( () => tls.createSecurePair({}), - { - code: 'ERR_ASSERTION', - message: 'context.context must be a NativeSecureContext' - } + 'context.context must be a NativeSecureContext' ); { |