test: remove unused assert module imports

Many test modules load assert but do not use it. This change removes
those instances.

It also removes a handful of other unused variables when they were
nearby.

PR-URL: https://github.com/nodejs/node/pull/4438
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

14 files changed, 5 insertions, 27 deletions

diff --git a/test/parallel/test-cluster-dgram-2.js b/test/parallel/test-cluster-dgram-2.js
index 0253cafcf4..6426e1c224 100644
--- a/test/parallel/test-cluster-dgram-2.js
+++ b/test/parallel/test-cluster-dgram-2.js
@@ -2,7 +2,6 @@
 var NUM_WORKERS = 4;
 var PACKETS_PER_WORKER = 10;
 
-var assert = require('assert');
 var cluster = require('cluster');
 var common = require('../common');
 var dgram = require('dgram');
diff --git a/test/parallel/test-cluster-rr-ref.js b/test/parallel/test-cluster-rr-ref.js
index 474e4d69f2..95d121df87 100644
--- a/test/parallel/test-cluster-rr-ref.js
+++ b/test/parallel/test-cluster-rr-ref.js
@@ -1,7 +1,6 @@
 'use strict';
 
 const common = require('../common');
-const assert = require('assert');
 const cluster = require('cluster');
 const net = require('net');
 
diff --git a/test/parallel/test-crypto-verify-failure.js b/test/parallel/test-crypto-verify-failure.js
index f315aed1a9..2bc4ce5433 100644
--- a/test/parallel/test-crypto-verify-failure.js
+++ b/test/parallel/test-crypto-verify-failure.js
@@ -1,6 +1,5 @@
 'use strict';
 var common = require('../common');
-var assert = require('assert');
 
 if (!common.hasCrypto) {
   console.log('1..0 # Skipped: missing crypto');
@@ -20,8 +19,6 @@ var options = {
   cert: fs.readFileSync(common.fixturesDir + '/keys/agent1-cert.pem')
 };
 
-var canSend = true;
-
 var server = tls.Server(options, function(socket) {
   setImmediate(function() {
     console.log('sending');
@@ -32,17 +29,15 @@ var server = tls.Server(options, function(socket) {
   });
 });
 
-var client;
-
 function verify() {
   console.log('verify');
-  var verified = crypto.createVerify('RSA-SHA1')
-                     .update('Test')
-                     .verify(certPem, 'asdfasdfas', 'base64');
+  crypto.createVerify('RSA-SHA1')
+    .update('Test')
+    .verify(certPem, 'asdfasdfas', 'base64');
 }
 
 server.listen(common.PORT, function() {
-  client = tls.connect({
+  tls.connect({
     port: common.PORT,
     rejectUnauthorized: false
   }, function() {
diff --git a/test/parallel/test-dgram-empty-packet.js b/test/parallel/test-dgram-empty-packet.js
index ba6faa62d8..66cdbb92ac 100644
--- a/test/parallel/test-dgram-empty-packet.js
+++ b/test/parallel/test-dgram-empty-packet.js
@@ -1,8 +1,6 @@
 'use strict';
 var common = require('../common');
-var assert = require('assert');
 
-var fs = require('fs');
 var dgram = require('dgram');
 var callbacks = 0;
 var client;
diff --git a/test/parallel/test-dgram-send-empty-buffer.js b/test/parallel/test-dgram-send-empty-buffer.js
index 11f3d38d2e..a8ab4339d8 100644
--- a/test/parallel/test-dgram-send-empty-buffer.js
+++ b/test/parallel/test-dgram-send-empty-buffer.js
@@ -1,10 +1,7 @@
 'use strict';
 var common = require('../common');
-var assert = require('assert');
 
-var fs = require('fs');
 var dgram = require('dgram');
-var callbacks = 0;
 var client, timer, buf;
 
 if (process.platform === 'darwin') {
diff --git a/test/parallel/test-domain-stack.js b/test/parallel/test-domain-stack.js
index 6f4d03ca5a..e30d3b21f3 100644
--- a/test/parallel/test-domain-stack.js
+++ b/test/parallel/test-domain-stack.js
@@ -2,9 +2,7 @@
 // Make sure that the domain stack doesn't get out of hand.
 
 require('../common');
-var assert = require('assert');
 var domain = require('domain');
-var events = require('events');
 
 var a = domain.create();
 a.name = 'a';
diff --git a/test/parallel/test-repl-domain.js b/test/parallel/test-repl-domain.js
index 0a3c7a609a..adc8478bee 100644
--- a/test/parallel/test-repl-domain.js
+++ b/test/parallel/test-repl-domain.js
@@ -1,11 +1,10 @@
 'use strict';
-var assert = require('assert');
 var common = require('../common');
 
 var repl   = require('repl');
 
 const putIn = new common.ArrayStream();
-var testMe = repl.start('', putIn);
+repl.start('', putIn);
 
 putIn.write = function(data) {
   // Don't use assert for this because the domain might catch it, and
diff --git a/test/parallel/test-require-extensions-main.js b/test/parallel/test-require-extensions-main.js
index 198fa6a8c5..0376082262 100644
--- a/test/parallel/test-require-extensions-main.js
+++ b/test/parallel/test-require-extensions-main.js
@@ -1,5 +1,4 @@
 'use strict';
 var common = require('../common');
-var assert = require('assert');
 
 require(common.fixturesDir + '/require-bin/bin/req.js');
diff --git a/test/parallel/test-stream-pipe-cleanup-pause.js b/test/parallel/test-stream-pipe-cleanup-pause.js
index b38f57a4ff..332930c813 100644
--- a/test/parallel/test-stream-pipe-cleanup-pause.js
+++ b/test/parallel/test-stream-pipe-cleanup-pause.js
@@ -1,6 +1,5 @@
 'use strict';
 const common = require('../common');
-const assert = require('assert');
 const stream = require('stream');
 
 const reader = new stream.Readable();
diff --git a/test/parallel/test-stream2-pipe-error-once-listener.js b/test/parallel/test-stream2-pipe-error-once-listener.js
index 3ca0782ea0..d046c5ea55 100644
--- a/test/parallel/test-stream2-pipe-error-once-listener.js
+++ b/test/parallel/test-stream2-pipe-error-once-listener.js
@@ -1,6 +1,5 @@
 'use strict';
 require('../common');
-var assert = require('assert');
 
 var util = require('util');
 var stream = require('stream');
diff --git a/test/parallel/test-timers-non-integer-delay.js b/test/parallel/test-timers-non-integer-delay.js
index 97b2c0734f..b42053db3b 100644
--- a/test/parallel/test-timers-non-integer-delay.js
+++ b/test/parallel/test-timers-non-integer-delay.js
@@ -16,7 +16,6 @@
  */
 
 require('../common');
-var assert = require('assert');
 
 var TIMEOUT_DELAY = 1.1;
 var NB_TIMEOUTS_FIRED = 50;
diff --git a/test/parallel/test-timers-socket-timeout-removes-other-socket-unref-timer.js b/test/parallel/test-timers-socket-timeout-removes-other-socket-unref-timer.js
index 081688cfa5..c9ca3eafd6 100644
--- a/test/parallel/test-timers-socket-timeout-removes-other-socket-unref-timer.js
+++ b/test/parallel/test-timers-socket-timeout-removes-other-socket-unref-timer.js
@@ -5,7 +5,6 @@
  */
 
 const common = require('../common');
-const assert = require('assert');
 const net = require('net');
 
 const clients = [];
diff --git a/test/parallel/test-timers-unref-remove-other-unref-timers.js b/test/parallel/test-timers-unref-remove-other-unref-timers.js
index 8c1864f1a7..dcc50a5171 100644
--- a/test/parallel/test-timers-unref-remove-other-unref-timers.js
+++ b/test/parallel/test-timers-unref-remove-other-unref-timers.js
@@ -7,7 +7,6 @@
  * considered public interface.
  */
 const common = require('../common');
-const assert = require('assert');
 const timers = require('timers');
 
 const foo = {
diff --git a/test/parallel/test-timers-unrefd-interval-still-fires.js b/test/parallel/test-timers-unrefd-interval-still-fires.js
index a716c6ed64..8f26d28816 100644
--- a/test/parallel/test-timers-unrefd-interval-still-fires.js
+++ b/test/parallel/test-timers-unrefd-interval-still-fires.js
@@ -3,7 +3,6 @@
  * This test is a regression test for joyent/node#8900.
  */
 const common = require('../common');
-const assert = require('assert');
 
 const TEST_DURATION = common.platformTimeout(100);
 const N = 5;