summaryrefslogtreecommitdiff
path: root/test/parallel
diff options
context:
space:
mode:
authorAnna Henningsen <anna@addaleax.net>2019-02-02 15:56:43 +0100
committerAnna Henningsen <anna@addaleax.net>2019-02-05 21:55:05 +0100
commit8d63f4037e52eda125c5a70dafa602f47c13d0ad (patch)
tree70c8ad00e315e3971cd57e62b7a2ef3635d2a468 /test/parallel
parent46d9573c682bbd8abe759cc2b76e2cf996cb7bcc (diff)
downloadandroid-node-v8-8d63f4037e52eda125c5a70dafa602f47c13d0ad.tar.gz
android-node-v8-8d63f4037e52eda125c5a70dafa602f47c13d0ad.tar.bz2
android-node-v8-8d63f4037e52eda125c5a70dafa602f47c13d0ad.zip
test,tracing: use close event to wait for stdio
Use `'close'` rather than `'exit'` to make sure that all stdio has been captured by the time that the event handler is run. PR-URL: https://github.com/nodejs/node/pull/25894 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Diffstat (limited to 'test/parallel')
-rw-r--r--test/parallel/test-trace-events-category-used.js4
1 files changed, 2 insertions, 2 deletions
diff --git a/test/parallel/test-trace-events-category-used.js b/test/parallel/test-trace-events-category-used.js
index bedc27bac4..f4b839dddc 100644
--- a/test/parallel/test-trace-events-category-used.js
+++ b/test/parallel/test-trace-events-category-used.js
@@ -28,7 +28,7 @@ let procEnabledOutput = '';
procEnabled.stdout.on('data', (data) => procEnabledOutput += data);
procEnabled.stderr.pipe(process.stderr);
-procEnabled.once('exit', common.mustCall(() => {
+procEnabled.once('close', common.mustCall(() => {
assert.strictEqual(procEnabledOutput, 'true\n');
}));
@@ -46,6 +46,6 @@ let procDisabledOutput = '';
procDisabled.stdout.on('data', (data) => procDisabledOutput += data);
procDisabled.stderr.pipe(process.stderr);
-procDisabled.once('exit', common.mustCall(() => {
+procDisabled.once('close', common.mustCall(() => {
assert.strictEqual(procDisabledOutput, 'false\n');
}));