fs: harden validation of start option in createWriteStream

PR-URL: https://github.com/nodejs/node/pull/25579
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

1 files changed, 17 insertions, 1 deletions

diff --git a/test/parallel/test-file-write-stream3.js b/test/parallel/test-file-write-stream3.js
index db16318a5c..618fbdf884 100644
--- a/test/parallel/test-file-write-stream3.js
+++ b/test/parallel/test-file-write-stream3.js
@@ -161,6 +161,7 @@ function run_test_3() {
     assert.strictEqual(fileData, fileDataExpected_3);
 
     run_test_4();
+    run_test_5();
   });
 
   file.on('error', function(err) {
@@ -184,7 +185,22 @@ const run_test_4 = common.mustCall(function() {
   const err = {
     code: 'ERR_OUT_OF_RANGE',
     message: 'The value of "start" is out of range. ' +
-             'It must be >= 0. Received {start: -5}',
+             'It must be >= 0 and <= 2 ** 53 - 1. Received -5',
+    type: RangeError
+  };
+  common.expectsError(fn, err);
+});
+
+
+const run_test_5 = common.mustCall(function() {
+  //  Error: start must be <= 2 ** 53 - 1
+  const fn = () => {
+    fs.createWriteStream(filepath, { start: 2 ** 53, flags: 'r+' });
+  };
+  const err = {
+    code: 'ERR_OUT_OF_RANGE',
+    message: 'The value of "start" is out of range. ' +
+             'It must be >= 0 and <= 2 ** 53 - 1. Received 9007199254740992',
     type: RangeError
   };
   common.expectsError(fn, err);