diff options
| author | Rich Trott <rtrott@gmail.com> | 2015-10-01 21:38:16 -0700 |
|---|---|---|
| committer | Rich Trott <rtrott@gmail.com> | 2015-10-06 15:11:58 -0700 |
| commit | 3de353b5544ec5863dc4e1291cdf1aed01b50358 (patch) | |
| tree | 7998c70ed474ce800b479314f86bcad32d4264a8 /test/parallel | |
| parent | c78091d689d0d4d56b3231b9050d52ca69ecb449 (diff) | |
| download | android-node-v8-3de353b5544ec5863dc4e1291cdf1aed01b50358.tar.gz android-node-v8-3de353b5544ec5863dc4e1291cdf1aed01b50358.tar.bz2 android-node-v8-3de353b5544ec5863dc4e1291cdf1aed01b50358.zip | |
test: make common.js mandatory via linting rule
test/common.js contains code that detects global variable leaks.
This eslint rule checks that a module named `common` is loaded. It is
only applicable to files in the test directory. Tests that intentionally
leak variables can opt out with an eslint-disable comment.
PR-URL: https://github.com/nodejs/node/pull/3157
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Diffstat (limited to 'test/parallel')
| -rw-r--r-- | test/parallel/test-domain-crypto.js | 2 | ||||
| -rw-r--r-- | test/parallel/test-regression-object-prototype.js | 2 | ||||
| -rw-r--r-- | test/parallel/test-repl-autolibs.js | 1 |
3 files changed, 3 insertions, 2 deletions
diff --git a/test/parallel/test-domain-crypto.js b/test/parallel/test-domain-crypto.js index 00de1aee27..e76e8d0879 100644 --- a/test/parallel/test-domain-crypto.js +++ b/test/parallel/test-domain-crypto.js @@ -1,4 +1,4 @@ -/* eslint-disable strict */ +/* eslint-disable strict, required-modules */ try { var crypto = require('crypto'); } catch (e) { diff --git a/test/parallel/test-regression-object-prototype.js b/test/parallel/test-regression-object-prototype.js index 040e718948..b1411bf813 100644 --- a/test/parallel/test-regression-object-prototype.js +++ b/test/parallel/test-regression-object-prototype.js @@ -1,5 +1,5 @@ +/* eslint-disable required-modules */ 'use strict'; -//console.log('puts before'); Object.prototype.xadsadsdasasdxx = function() { }; diff --git a/test/parallel/test-repl-autolibs.js b/test/parallel/test-repl-autolibs.js index 4103a19243..e37f2d036e 100644 --- a/test/parallel/test-repl-autolibs.js +++ b/test/parallel/test-repl-autolibs.js @@ -1,3 +1,4 @@ +/* eslint-disable required-modules */ 'use strict'; var assert = require('assert'); var util = require('util'); |