summaryrefslogtreecommitdiff
path: root/test/parallel
diff options
context:
space:
mode:
authorSam Roberts <vieuxtech@gmail.com>2019-02-01 12:00:01 -0800
committerSam Roberts <vieuxtech@gmail.com>2019-02-06 15:18:18 -0800
commit1bd42833d7ac3b5cc9737c6cc7dc8d69a4102ba5 (patch)
tree9b17756496adae3fc0243a137faf04bb22c55f84 /test/parallel
parentbca2e219a36372d94fe420d314ca3b2ad896f67b (diff)
downloadandroid-node-v8-1bd42833d7ac3b5cc9737c6cc7dc8d69a4102ba5.tar.gz
android-node-v8-1bd42833d7ac3b5cc9737c6cc7dc8d69a4102ba5.tar.bz2
android-node-v8-1bd42833d7ac3b5cc9737c6cc7dc8d69a4102ba5.zip
test: end tls gracefully, rather than destroy
The timing of destroy between client/server is undefined, but end is guaranteed to occur. PR-URL: https://github.com/nodejs/node/pull/25508 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'test/parallel')
-rw-r--r--test/parallel/test-tls-sni-option.js2
-rw-r--r--test/parallel/test-tls-sni-server-client.js2
2 files changed, 2 insertions, 2 deletions
diff --git a/test/parallel/test-tls-sni-option.js b/test/parallel/test-tls-sni-option.js
index 375575c78a..3a6a231b47 100644
--- a/test/parallel/test-tls-sni-option.js
+++ b/test/parallel/test-tls-sni-option.js
@@ -115,6 +115,7 @@ let clientError;
const server = tls.createServer(serverOptions, function(c) {
serverResults.push({ sni: c.servername, authorized: c.authorized });
+ c.end();
});
server.on('tlsClientError', function(err) {
@@ -135,7 +136,6 @@ function startTest() {
clientResults.push(
client.authorizationError &&
(client.authorizationError === 'ERR_TLS_CERT_ALTNAME_INVALID'));
- client.destroy();
next();
});
diff --git a/test/parallel/test-tls-sni-server-client.js b/test/parallel/test-tls-sni-server-client.js
index 073e95988a..8ab025667e 100644
--- a/test/parallel/test-tls-sni-server-client.js
+++ b/test/parallel/test-tls-sni-server-client.js
@@ -86,6 +86,7 @@ const clientResults = [];
const server = tls.createServer(serverOptions, function(c) {
serverResults.push(c.servername);
+ c.end();
});
server.addContext('a.example.com', SNIContexts['a.example.com']);
@@ -107,7 +108,6 @@ function startTest() {
clientResults.push(
client.authorizationError &&
(client.authorizationError === 'ERR_TLS_CERT_ALTNAME_INVALID'));
- client.destroy();
// Continue
start();