summaryrefslogtreecommitdiff
path: root/test/parallel/test-worker-uncaught-exception.js
diff options
context:
space:
mode:
authorAnna Henningsen <anna@addaleax.net>2017-09-26 01:42:16 +0200
committerAnna Henningsen <anna@addaleax.net>2018-06-06 19:43:59 +0200
commitd1c096cc9d88a865094b91ef86b771cd23d8bfe7 (patch)
treef52222e455d3b953d69388fb542b4343d810e492 /test/parallel/test-worker-uncaught-exception.js
parent6d59bfb4f823e30e291a6841410e324879f6486e (diff)
downloadandroid-node-v8-d1c096cc9d88a865094b91ef86b771cd23d8bfe7.tar.gz
android-node-v8-d1c096cc9d88a865094b91ef86b771cd23d8bfe7.tar.bz2
android-node-v8-d1c096cc9d88a865094b91ef86b771cd23d8bfe7.zip
worker: improve error (de)serialization
Rather than passing errors using some sort of string representation, do a best effort for faithful serialization/deserialization of uncaught exception objects. PR-URL: https://github.com/nodejs/node/pull/20876 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Shingo Inoue <leko.noor@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: John-David Dalton <john.david.dalton@gmail.com> Reviewed-By: Gus Caplan <me@gus.host>
Diffstat (limited to 'test/parallel/test-worker-uncaught-exception.js')
-rw-r--r--test/parallel/test-worker-uncaught-exception.js3
1 files changed, 1 insertions, 2 deletions
diff --git a/test/parallel/test-worker-uncaught-exception.js b/test/parallel/test-worker-uncaught-exception.js
index b0e3ad11fa..cb2a0d79d2 100644
--- a/test/parallel/test-worker-uncaught-exception.js
+++ b/test/parallel/test-worker-uncaught-exception.js
@@ -10,8 +10,7 @@ if (!process.env.HAS_STARTED_WORKER) {
const w = new Worker(__filename);
w.on('message', common.mustNotCall());
w.on('error', common.mustCall((err) => {
- // TODO(addaleax): be more specific here
- assert(/foo/.test(err));
+ assert(/^Error: foo$/.test(err));
}));
} else {
throw new Error('foo');