test: refactor `common.expectWarning()`

The current API is somewhat confusing at times and simpler usage is
possible. This overloads the arguments further to accept objects
with deprecation codes as property keys. It also adds documentation
for the different possible styles.

Besides that it is now going to validate for the code being present
in case of deprecations but not for other cases. The former validation
was not consistent as it only validated some cases and accepted
undefined instead of `common.noWarnCode`. This check is removed due to
the lack of consistency. `common.noWarnCode` is completely removed
due to just being sugar for `undefined`.

This also verifies that the warning order is identical to the order
in which they are triggered.

PR-URL: https://github.com/nodejs/node/pull/25251
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

1 files changed, 1 insertions, 2 deletions

diff --git a/test/parallel/test-worker-message-port-transfer-target.js b/test/parallel/test-worker-message-port-transfer-target.js
index 0b1d537bd3..638591023f 100644
--- a/test/parallel/test-worker-message-port-transfer-target.js
+++ b/test/parallel/test-worker-message-port-transfer-target.js
@@ -10,8 +10,7 @@ const arrayBuf = new ArrayBuffer(10);
 
 common.expectWarning('Warning',
                      'The target port was posted to itself, and the ' +
-                     'communication channel was lost',
-                     common.noWarnCode);
+                     'communication channel was lost');
 port2.onmessage = common.mustNotCall();
 port2.postMessage(null, [port1, arrayBuf]);