summaryrefslogtreecommitdiff
path: root/test/parallel/test-whatwg-url-custom-searchparams-sort.js
diff options
context:
space:
mode:
authorJoyee Cheung <joyeec9h3@gmail.com>2018-09-16 15:00:40 +0800
committerJoyee Cheung <joyeec9h3@gmail.com>2018-11-09 20:27:21 +0800
commit9858e331e3e461e24916c3e86087e5a73b3cb468 (patch)
treeab97459f9e414b1feaab2dbb776a3e29948dae44 /test/parallel/test-whatwg-url-custom-searchparams-sort.js
parent1357913180fcce97c447d1d5e3acbf0bbcc39b8c (diff)
downloadandroid-node-v8-9858e331e3e461e24916c3e86087e5a73b3cb468.tar.gz
android-node-v8-9858e331e3e461e24916c3e86087e5a73b3cb468.tar.bz2
android-node-v8-9858e331e3e461e24916c3e86087e5a73b3cb468.zip
test: initialize test/wpt to run URL and console .js tests
This patch: - Creates a new test suite `wpt` that can be used to run a subset of Web Platform Tests - Adds a `WPTRunner` in `test/common/wpt.js` that can run the WPT subset in `test/fixtures/wpt` with a vm and the WPT harness while taking the status file in `test/wpt/status` into account. Here we use a new format of status file (in JSON) to handle specific requirements (like ICU requirements) in the tests and to handle expected failures and TODOs. - Adds documentation on how the runner and the update automation works - Runs the WHATWG URL tests and the console tests with the new test runner. With this patch we eliminates the need of copy-pasting with manual modifications to update a large chunk of our WPT subset previously maintained in `test/parallel`. Now the tests run in `test/wpt` can be automatically updated with `git node wpt` without modifications by the actual WPT harness instead of our home-grown mock. There are still a few URL tests left that need to be migrated in the upstream to be placed in .js instead of .html - we currently still use the legacy harness mock in the test files. PR-URL: https://github.com/nodejs/node/pull/24035 Refs: https://github.com/nodejs/node/issues/23192 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Diffstat (limited to 'test/parallel/test-whatwg-url-custom-searchparams-sort.js')
-rw-r--r--test/parallel/test-whatwg-url-custom-searchparams-sort.js9
1 files changed, 7 insertions, 2 deletions
diff --git a/test/parallel/test-whatwg-url-custom-searchparams-sort.js b/test/parallel/test-whatwg-url-custom-searchparams-sort.js
index f8884a7e70..49c3b065f9 100644
--- a/test/parallel/test-whatwg-url-custom-searchparams-sort.js
+++ b/test/parallel/test-whatwg-url-custom-searchparams-sort.js
@@ -4,9 +4,14 @@
require('../common');
const { URL, URLSearchParams } = require('url');
-const { test, assert_array_equals } = require('../common/wpt');
+const { test, assert_array_equals } = require('../common/wpt').harness;
-// Test bottom-up iterative stable merge sort
+// TODO(joyeecheung): upstream this to WPT, if possible - even
+// just as a test for large inputs. Other implementations may
+// have a similar cutoff anyway.
+
+// Test bottom-up iterative stable merge sort because we only use that
+// algorithm to sort > 100 search params.
const tests = [{ input: '', output: [] }];
const pairs = [];
for (let i = 10; i < 100; i++) {