summaryrefslogtreecommitdiff
path: root/test/parallel/test-vm-static-this.js
diff options
context:
space:
mode:
authorDavid Bradford <dbradf@gmail.com>2016-12-01 10:02:09 -0600
committercjihrig <cjihrig@gmail.com>2016-12-04 10:35:30 -0500
commit1a324f2b8551a431e0d6e9597f073ae2694cc484 (patch)
treeede23d9348f8cd1915280c899fe22beac9ec9c78 /test/parallel/test-vm-static-this.js
parent07ef682c510ed019fe578370b7f4fc98c93590f6 (diff)
downloadandroid-node-v8-1a324f2b8551a431e0d6e9597f073ae2694cc484.tar.gz
android-node-v8-1a324f2b8551a431e0d6e9597f073ae2694cc484.tar.bz2
android-node-v8-1a324f2b8551a431e0d6e9597f073ae2694cc484.zip
test: refactor test-vm-static-this.js
Remove console statements and prefer strictEqual() over equal() in assertions. PR-URL: https://github.com/nodejs/node/pull/9887 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Diffstat (limited to 'test/parallel/test-vm-static-this.js')
-rw-r--r--test/parallel/test-vm-static-this.js20
1 files changed, 10 insertions, 10 deletions
diff --git a/test/parallel/test-vm-static-this.js b/test/parallel/test-vm-static-this.js
index a3cf2d820c..c4f10c183b 100644
--- a/test/parallel/test-vm-static-this.js
+++ b/test/parallel/test-vm-static-this.js
@@ -5,21 +5,21 @@ var vm = require('vm');
common.globalCheck = false;
-console.error('run a string');
+// Run a string
var result = vm.runInThisContext('\'passed\';');
-assert.equal('passed', result);
+assert.strictEqual('passed', result);
-console.error('thrown error');
+// thrown error
assert.throws(function() {
vm.runInThisContext('throw new Error(\'test\');');
}, /test/);
global.hello = 5;
vm.runInThisContext('hello = 2');
-assert.equal(2, global.hello);
+assert.strictEqual(2, global.hello);
-console.error('pass values');
+// pass values
var code = 'foo = 1;' +
'bar = 2;' +
'if (typeof baz !== \'undefined\') throw new Error(\'test fail\');';
@@ -28,11 +28,11 @@ global.obj = { foo: 0, baz: 3 };
/* eslint-disable no-unused-vars */
var baz = vm.runInThisContext(code);
/* eslint-enable no-unused-vars */
-assert.equal(0, global.obj.foo);
-assert.equal(2, global.bar);
-assert.equal(1, global.foo);
+assert.strictEqual(0, global.obj.foo);
+assert.strictEqual(2, global.bar);
+assert.strictEqual(1, global.foo);
-console.error('call a function');
+// call a function
global.f = function() { global.foo = 100; };
vm.runInThisContext('f()');
-assert.equal(100, global.foo);
+assert.strictEqual(100, global.foo);