diff options
author | Gus Caplan <me@gus.host> | 2019-09-09 12:20:16 -0500 |
---|---|---|
committer | Rich Trott <rtrott@gmail.com> | 2019-10-02 15:54:35 -0700 |
commit | 5e7946fe79193633e9a78aae48548635cbc11023 (patch) | |
tree | 4ef3ab236df6aa8d570e22453dbe56b37487ad63 /test/parallel/test-vm-module-reevaluate.js | |
parent | 6ba9471f6fcaaf377f22621c4d193d30e3877566 (diff) | |
download | android-node-v8-5e7946fe79193633e9a78aae48548635cbc11023.tar.gz android-node-v8-5e7946fe79193633e9a78aae48548635cbc11023.tar.bz2 android-node-v8-5e7946fe79193633e9a78aae48548635cbc11023.zip |
vm: refactor SourceTextModule
- Removes redundant `instantiate` method
- Refactors `link` to match the spec linking steps more accurately
- Removes URL validation from SourceTextModule specifiers
- DRYs some dynamic import logic
Closes: https://github.com/nodejs/node/issues/29030
Co-Authored-By: Michaël Zasso <targos@protonmail.com>
PR-URL: https://github.com/nodejs/node/pull/29776
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Diffstat (limited to 'test/parallel/test-vm-module-reevaluate.js')
-rw-r--r-- | test/parallel/test-vm-module-reevaluate.js | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/test/parallel/test-vm-module-reevaluate.js b/test/parallel/test-vm-module-reevaluate.js index c3914f362f..4767541dd2 100644 --- a/test/parallel/test-vm-module-reevaluate.js +++ b/test/parallel/test-vm-module-reevaluate.js @@ -14,7 +14,6 @@ const finished = common.mustCall(); { const m = new SourceTextModule('1'); await m.link(common.mustNotCall()); - m.instantiate(); assert.strictEqual((await m.evaluate()).result, 1); assert.strictEqual((await m.evaluate()).result, undefined); assert.strictEqual((await m.evaluate()).result, undefined); @@ -23,7 +22,6 @@ const finished = common.mustCall(); { const m = new SourceTextModule('throw new Error()'); await m.link(common.mustNotCall()); - m.instantiate(); let threw = false; try { |