diff options
author | Gus Caplan <me@gus.host> | 2019-09-09 12:20:16 -0500 |
---|---|---|
committer | Rich Trott <rtrott@gmail.com> | 2019-10-02 15:54:35 -0700 |
commit | 5e7946fe79193633e9a78aae48548635cbc11023 (patch) | |
tree | 4ef3ab236df6aa8d570e22453dbe56b37487ad63 /test/parallel/test-vm-module-dynamic-import.js | |
parent | 6ba9471f6fcaaf377f22621c4d193d30e3877566 (diff) | |
download | android-node-v8-5e7946fe79193633e9a78aae48548635cbc11023.tar.gz android-node-v8-5e7946fe79193633e9a78aae48548635cbc11023.tar.bz2 android-node-v8-5e7946fe79193633e9a78aae48548635cbc11023.zip |
vm: refactor SourceTextModule
- Removes redundant `instantiate` method
- Refactors `link` to match the spec linking steps more accurately
- Removes URL validation from SourceTextModule specifiers
- DRYs some dynamic import logic
Closes: https://github.com/nodejs/node/issues/29030
Co-Authored-By: Michaël Zasso <targos@protonmail.com>
PR-URL: https://github.com/nodejs/node/pull/29776
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Diffstat (limited to 'test/parallel/test-vm-module-dynamic-import.js')
-rw-r--r-- | test/parallel/test-vm-module-dynamic-import.js | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/test/parallel/test-vm-module-dynamic-import.js b/test/parallel/test-vm-module-dynamic-import.js index 600f455e93..897d9f27d7 100644 --- a/test/parallel/test-vm-module-dynamic-import.js +++ b/test/parallel/test-vm-module-dynamic-import.js @@ -10,7 +10,6 @@ const { Script, SourceTextModule, createContext } = require('vm'); async function testNoCallback() { const m = new SourceTextModule('import("foo")', { context: createContext() }); await m.link(common.mustNotCall()); - m.instantiate(); const { result } = await m.evaluate(); let threw = false; try { @@ -25,7 +24,6 @@ async function testNoCallback() { async function test() { const foo = new SourceTextModule('export const a = 1;'); await foo.link(common.mustNotCall()); - foo.instantiate(); await foo.evaluate(); { @@ -50,7 +48,6 @@ async function test() { }), }); await m.link(common.mustNotCall()); - m.instantiate(); const { result } = await m.evaluate(); assert.strictEqual(foo.namespace, await result); } @@ -63,7 +60,6 @@ async function testInvalid() { }), }); await m.link(common.mustNotCall()); - m.instantiate(); const { result } = await m.evaluate(); await result.catch(common.mustCall((e) => { assert.strictEqual(e.code, 'ERR_VM_MODULE_NOT_MODULE'); |