diff options
| author | Ruben Bridgewater <ruben@bridgewater.de> | 2018-04-26 05:44:14 +0200 |
|---|---|---|
| committer | Ruben Bridgewater <ruben@bridgewater.de> | 2018-04-29 17:17:14 +0200 |
| commit | 541d2192cf0325f6b085a33828b40a0e5b23b76a (patch) | |
| tree | e6d6fbebb02b1a615af6aaf4ca85431bf6bf19d8 /test/parallel/test-util-isDeepStrictEqual.js | |
| parent | 29cddb40b238daf1dfad0cc42e0d3bd5068dff03 (diff) | |
| download | android-node-v8-541d2192cf0325f6b085a33828b40a0e5b23b76a.tar.gz android-node-v8-541d2192cf0325f6b085a33828b40a0e5b23b76a.tar.bz2 android-node-v8-541d2192cf0325f6b085a33828b40a0e5b23b76a.zip | |
test: fix a TODO and remove obsolete TODOs
This removes outdated TODOs and adds a test for invalid input in
`fs.copyFile` and solves a TODO by doing so.
PR-URL: https://github.com/nodejs/node/pull/20319
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'test/parallel/test-util-isDeepStrictEqual.js')
| -rw-r--r-- | test/parallel/test-util-isDeepStrictEqual.js | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/test/parallel/test-util-isDeepStrictEqual.js b/test/parallel/test-util-isDeepStrictEqual.js index 356a9a7132..938781a430 100644 --- a/test/parallel/test-util-isDeepStrictEqual.js +++ b/test/parallel/test-util-isDeepStrictEqual.js @@ -419,8 +419,6 @@ notUtilIsDeepStrict([1, , , 3], [1, , , 3, , , ]); const err3 = new TypeError('foo1'); notUtilIsDeepStrict(err1, err2, assert.AssertionError); notUtilIsDeepStrict(err1, err3, assert.AssertionError); - // TODO: evaluate if this should throw or not. The same applies for RegExp - // Date and any object that has the same keys but not the same prototype. notUtilIsDeepStrict(err1, {}, assert.AssertionError); } |