summaryrefslogtreecommitdiff
path: root/test/parallel/test-util-inspect.js
diff options
context:
space:
mode:
authorRuben Bridgewater <ruben@bridgewater.de>2018-02-09 02:32:04 +0100
committerRuben Bridgewater <ruben@bridgewater.de>2018-02-16 16:53:47 +0100
commitcaee112e52b64f4bc1118c4a5fa5ad7b4211efea (patch)
tree7b60b49da3f863917a23ebc94c00bf2f13cc1348 /test/parallel/test-util-inspect.js
parent4d3c3f039af08b954fbbba1e9a50979ffc98592b (diff)
downloadandroid-node-v8-caee112e52b64f4bc1118c4a5fa5ad7b4211efea.tar.gz
android-node-v8-caee112e52b64f4bc1118c4a5fa5ad7b4211efea.tar.bz2
android-node-v8-caee112e52b64f4bc1118c4a5fa5ad7b4211efea.zip
test: remove assert.doesNotThrow()
There is actually no reason to use `assert.doesNotThrow()` in the tests. If a test throws, just let the error bubble up right away instead of first catching it and then rethrowing it. PR-URL: https://github.com/nodejs/node/pull/18669 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Diffstat (limited to 'test/parallel/test-util-inspect.js')
-rw-r--r--test/parallel/test-util-inspect.js32
1 files changed, 13 insertions, 19 deletions
diff --git a/test/parallel/test-util-inspect.js b/test/parallel/test-util-inspect.js
index 31759a372c..4f717e2d6b 100644
--- a/test/parallel/test-util-inspect.js
+++ b/test/parallel/test-util-inspect.js
@@ -537,30 +537,26 @@ assert.strictEqual(util.inspect(-5e-324), '-5e-324');
assert.strictEqual(util.inspect(Object.create(Date.prototype)), 'Date {}');
// GH-1944
-assert.doesNotThrow(() => {
+{
const d = new Date();
d.toUTCString = null;
util.inspect(d);
-});
+}
-assert.doesNotThrow(() => {
+{
const d = new Date();
d.toISOString = null;
util.inspect(d);
-});
+}
-assert.doesNotThrow(() => {
- const r = /regexp/;
- r.toString = null;
- util.inspect(r);
-});
+const r = /regexp/;
+r.toString = null;
+util.inspect(r);
// bug with user-supplied inspect function returns non-string
-assert.doesNotThrow(() => {
- util.inspect([{
- inspect: () => 123
- }]);
-});
+util.inspect([{
+ inspect: () => 123
+}]);
// GH-2225
{
@@ -624,10 +620,8 @@ assert.doesNotThrow(() => {
}
// an object with "hasOwnProperty" overwritten should not throw
-assert.doesNotThrow(() => {
- util.inspect({
- hasOwnProperty: null
- });
+util.inspect({
+ hasOwnProperty: null
});
// new API, accepts an "options" object
@@ -1157,7 +1151,7 @@ if (typeof Symbol !== 'undefined') {
);
}
-assert.doesNotThrow(() => util.inspect(process));
+util.inspect(process);
// Setting custom inspect property to a non-function should do nothing.
{