diff options
| author | Anna Henningsen <anna@addaleax.net> | 2018-11-30 07:39:02 +0100 |
|---|---|---|
| committer | Daniel Bevenius <daniel.bevenius@gmail.com> | 2018-12-06 05:21:36 +0100 |
| commit | aa943d098e0299ea87485a607353d152f5ea5012 (patch) | |
| tree | b3f2cd52efc4568d5f7deb6ca99684e2f5d22a62 /test/parallel/test-trace-events-metadata.js | |
| parent | 7bcbf044ddc864be9d6c711a75f3a33b6a3c652e (diff) | |
| download | android-node-v8-aa943d098e0299ea87485a607353d152f5ea5012.tar.gz android-node-v8-aa943d098e0299ea87485a607353d152f5ea5012.tar.bz2 android-node-v8-aa943d098e0299ea87485a607353d152f5ea5012.zip | |
http: make parser choice a runtime flag
Add a `--http-parser=llhttp` vs `--http-parser=traditional`
command line switch, to make testing and comparing the new
llhttp-based implementation easier.
PR-URL: https://github.com/nodejs/node/pull/24739
Refs: https://github.com/nodejs/node/issues/24730
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Diffstat (limited to 'test/parallel/test-trace-events-metadata.js')
| -rw-r--r-- | test/parallel/test-trace-events-metadata.js | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/test/parallel/test-trace-events-metadata.js b/test/parallel/test-trace-events-metadata.js index 0db8555838..863b2175f6 100644 --- a/test/parallel/test-trace-events-metadata.js +++ b/test/parallel/test-trace-events-metadata.js @@ -36,9 +36,10 @@ proc.once('exit', common.mustCall(() => { assert(traces.some((trace) => trace.name === 'node' && - (trace.args.process.versions.http_parser === - process.versions.http_parser || - trace.args.process.versions.llhttp === process.versions.llhttp) && + trace.args.process.versions.http_parser === + process.versions.http_parser && + trace.args.process.versions.llhttp === + process.versions.llhttp && trace.args.process.versions.node === process.versions.node && trace.args.process.versions.v8 === |