diff options
author | Richard Lau <riclau@uk.ibm.com> | 2018-10-16 13:28:52 -0400 |
---|---|---|
committer | Daniel Bevenius <daniel.bevenius@gmail.com> | 2018-10-19 07:22:54 +0200 |
commit | 23f8b7d334db86a78464f8694c015afab6dedfc3 (patch) | |
tree | 055d5d313cd090ce858100094a9620ea9f1ea870 /test/parallel/test-trace-events-file-pattern.js | |
parent | 15c336684fd552e1f5cd256326ba33c81f43c825 (diff) | |
download | android-node-v8-23f8b7d334db86a78464f8694c015afab6dedfc3.tar.gz android-node-v8-23f8b7d334db86a78464f8694c015afab6dedfc3.tar.bz2 android-node-v8-23f8b7d334db86a78464f8694c015afab6dedfc3.zip |
test: enable trace-events tests for workers
Use the `cwd` option for `child_process` instead of `process.chdir()`
to enable the trace events tests to run on workers.
PR-URL: https://github.com/nodejs/node/pull/23698
Refs: https://github.com/nodejs/node/pull/23674#discussion_r225335819
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Diffstat (limited to 'test/parallel/test-trace-events-file-pattern.js')
-rw-r--r-- | test/parallel/test-trace-events-file-pattern.js | 10 |
1 files changed, 4 insertions, 6 deletions
diff --git a/test/parallel/test-trace-events-file-pattern.js b/test/parallel/test-trace-events-file-pattern.js index 60a3296c64..a60559b7f9 100644 --- a/test/parallel/test-trace-events-file-pattern.js +++ b/test/parallel/test-trace-events-file-pattern.js @@ -4,12 +4,9 @@ const tmpdir = require('../common/tmpdir'); const assert = require('assert'); const cp = require('child_process'); const fs = require('fs'); - -if (!common.isMainThread) - common.skip('process.chdir is not available in Workers'); +const path = require('path'); tmpdir.refresh(); -process.chdir(tmpdir.path); const CODE = 'setTimeout(() => { for (var i = 0; i < 100000; i++) { "test" + i } }, 1)'; @@ -20,10 +17,11 @@ const proc = cp.spawn(process.execPath, [ // eslint-disable-next-line no-template-curly-in-string '${pid}-${rotation}-${pid}-${rotation}.tracing.log', '-e', CODE -]); +], { cwd: tmpdir.path }); proc.once('exit', common.mustCall(() => { - const expectedFilename = `${proc.pid}-1-${proc.pid}-1.tracing.log`; + const expectedFilename = path.join(tmpdir.path, + `${proc.pid}-1-${proc.pid}-1.tracing.log`); assert(fs.existsSync(expectedFilename)); fs.readFile(expectedFilename, common.mustCall((err, data) => { |