diff options
author | Ali Ijaz Sheikh <ofrobots@google.com> | 2018-10-11 06:33:25 -0700 |
---|---|---|
committer | Anna Henningsen <anna@addaleax.net> | 2018-10-12 14:12:31 -0700 |
commit | f5986a464316e2c7c2a21f5a5e9ffa7e527fd9d4 (patch) | |
tree | 469a2299ba6eb95cf2a27d9dcce886da09479f37 /test/parallel/test-trace-events-dynamic-enable.js | |
parent | b4e979ff84bbd366218ddba73ce7f275415b3569 (diff) | |
download | android-node-v8-f5986a464316e2c7c2a21f5a5e9ffa7e527fd9d4.tar.gz android-node-v8-f5986a464316e2c7c2a21f5a5e9ffa7e527fd9d4.tar.bz2 android-node-v8-f5986a464316e2c7c2a21f5a5e9ffa7e527fd9d4.zip |
src: trace_event: secondary storage for metadata
Metadata trace-events should be held in secondary storage so that they
can be periodically reemitted. This change establishes the secondary
storage and ensures that events are reemitted on each flush.
PR-URL: https://github.com/nodejs/node/pull/20900
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Diffstat (limited to 'test/parallel/test-trace-events-dynamic-enable.js')
-rw-r--r-- | test/parallel/test-trace-events-dynamic-enable.js | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/test/parallel/test-trace-events-dynamic-enable.js b/test/parallel/test-trace-events-dynamic-enable.js index 24a186c15a..645dcb2764 100644 --- a/test/parallel/test-trace-events-dynamic-enable.js +++ b/test/parallel/test-trace-events-dynamic-enable.js @@ -25,9 +25,12 @@ function post(message, data) { async function test() { session.connect(); - let traceNotification = null; + const events = []; let tracingComplete = false; - session.on('NodeTracing.dataCollected', (n) => traceNotification = n); + session.on('NodeTracing.dataCollected', (n) => { + assert.ok(n && n.data && n.data.value); + events.push(...n.data.value); // append the events. + }); session.on('NodeTracing.tracingComplete', () => tracingComplete = true); // Generate a node.perf event before tracing is enabled. @@ -47,10 +50,7 @@ async function test() { session.disconnect(); assert.ok(tracingComplete); - assert.ok(traceNotification); - assert.ok(traceNotification.data && traceNotification.data.value); - const events = traceNotification.data.value; const marks = events.filter((t) => null !== /node\.perf\.usertim/.exec(t.cat)); assert.strictEqual(marks.length, 1); assert.strictEqual(marks[0].name, 'mark2'); |