diff options
| author | David Benjamin <davidben@google.com> | 2017-09-17 18:48:25 -0400 |
|---|---|---|
| committer | Rod Vagg <rod@vagg.org> | 2017-11-11 20:42:49 +1100 |
| commit | ffb8f031a4559f89b6967e3a1eb0cbdb24657bb0 (patch) | |
| tree | 2d7fb6fbe7f1a20cb3d567f3cce92bec9d0b25d9 /test/parallel/test-tls-no-sslv3.js | |
| parent | 5fe81c8aff03261f6443580dbc08f608013718c6 (diff) | |
| download | android-node-v8-ffb8f031a4559f89b6967e3a1eb0cbdb24657bb0.tar.gz android-node-v8-ffb8f031a4559f89b6967e3a1eb0cbdb24657bb0.tar.bz2 android-node-v8-ffb8f031a4559f89b6967e3a1eb0cbdb24657bb0.zip | |
test: update test expectations for OpenSSL 1.1.0
Some errors in the two versions are different. The test-tls-no-sslv3 one
because OpenSSL 1.1.x finally does version negotiation properly. 1.0.x's
logic was somewhat weird and resulted in very inconsistent errors for
SSLv3 in particular.
Also the function codes are capitalized differently, but function codes
leak implementation details, so don't assert on them to begin with.
PR-URL: https://github.com/nodejs/node/pull/16130
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Rod Vagg <rod@vagg.org>
Diffstat (limited to 'test/parallel/test-tls-no-sslv3.js')
| -rw-r--r-- | test/parallel/test-tls-no-sslv3.js | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/test/parallel/test-tls-no-sslv3.js b/test/parallel/test-tls-no-sslv3.js index 9622262f38..aa37fc2e3b 100644 --- a/test/parallel/test-tls-no-sslv3.js +++ b/test/parallel/test-tls-no-sslv3.js @@ -46,6 +46,8 @@ process.on('exit', function() { common.printSkipMessage('`openssl s_client -ssl3` not supported.'); } else { assert.strictEqual(errors.length, 1); - assert(/:wrong version number/.test(errors[0].message)); + // OpenSSL 1.0.x and 1.1.x report invalid client versions differently. + assert(/:wrong version number/.test(errors[0].message) || + /:version too low/.test(errors[0].message)); } }); |