diff options
| author | Shigeki Ohtsu <ohtsu@iij.ad.jp> | 2015-07-18 11:59:55 +0900 |
|---|---|---|
| committer | Shigeki Ohtsu <ohtsu@iij.ad.jp> | 2015-07-22 10:17:09 +0900 |
| commit | ac7d3fa0d93001d8143f66bf793e66afbf2f76ff (patch) | |
| tree | ba011a0cadc4d55dc395e3173242fae76c53c94e /test/parallel/test-tls-no-sslv3.js | |
| parent | f90f1e75bb8aa5359cffc2539b31a7cd3d866913 (diff) | |
| download | android-node-v8-ac7d3fa0d93001d8143f66bf793e66afbf2f76ff.tar.gz android-node-v8-ac7d3fa0d93001d8143f66bf793e66afbf2f76ff.tar.bz2 android-node-v8-ac7d3fa0d93001d8143f66bf793e66afbf2f76ff.zip | |
test: add -no_rand_screen to s_client opts on Win
RAND_screen() causes stability issues in invoking openssl-cli s_client
on win2008r2 in CI. Disable to use it by adding -no_rand_screen
options to all tls tests that use common.opensslCli.
Fixes: https://github.com/nodejs/io.js/issues/2150
PR-URL: https://github.com/nodejs/io.js/pull/2209
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Joao Reis <reis@janeasystems.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Diffstat (limited to 'test/parallel/test-tls-no-sslv3.js')
| -rw-r--r-- | test/parallel/test-tls-no-sslv3.js | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/test/parallel/test-tls-no-sslv3.js b/test/parallel/test-tls-no-sslv3.js index 2671bbcad5..e4a4df1481 100644 --- a/test/parallel/test-tls-no-sslv3.js +++ b/test/parallel/test-tls-no-sslv3.js @@ -29,6 +29,11 @@ server.listen(common.PORT, '127.0.0.1', function() { '-no_tls1_1', '-no_tls1_2', '-connect', address]; + + // for the performance and stability issue in s_client on Windows + if (process.platform === 'win32') + args.push('-no_rand_screen'); + var client = spawn(common.opensslCli, args, { stdio: 'inherit' }); client.once('exit', common.mustCall(function(exitCode) { assert.equal(exitCode, 1); |