diff options
| author | Anna Henningsen <anna@addaleax.net> | 2018-11-10 22:05:15 +0100 |
|---|---|---|
| committer | Anna Henningsen <anna@addaleax.net> | 2018-11-15 15:33:35 +0100 |
| commit | c347e77647ed7c25d2eba4860ce62dbddaa46307 (patch) | |
| tree | 9836661d8119d70dccee78953f0806bbbc5fbfe7 /test/parallel/test-tls-invoke-queued.js | |
| parent | 3212f77ac6d674a7d43c3303dcca22508c8be468 (diff) | |
| download | android-node-v8-c347e77647ed7c25d2eba4860ce62dbddaa46307.tar.gz android-node-v8-c347e77647ed7c25d2eba4860ce62dbddaa46307.tar.bz2 android-node-v8-c347e77647ed7c25d2eba4860ce62dbddaa46307.zip | |
net: always invoke after-write callback
This is part of the streams API contract, and aligns
network sockets with other streams in this respect.
PR-URL: https://github.com/nodejs/node/pull/24291
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Diffstat (limited to 'test/parallel/test-tls-invoke-queued.js')
| -rw-r--r-- | test/parallel/test-tls-invoke-queued.js | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/test/parallel/test-tls-invoke-queued.js b/test/parallel/test-tls-invoke-queued.js index 754b02ba0b..482ab84735 100644 --- a/test/parallel/test-tls-invoke-queued.js +++ b/test/parallel/test-tls-invoke-queued.js @@ -40,8 +40,8 @@ const server = tls.createServer({ c.write('world!', null, common.mustCall(function() { c.destroy(); })); - // Data on next _write() will be written but callback will not be invoked - c.write(' gosh', null, common.mustNotCall()); + // Data on next _write() will be written, and the cb will still be invoked + c.write(' gosh', null, common.mustCall()); })); server.close(); |