test: use random ports where possible

This helps to prevent issues where a failed test can keep a bound
socket open long enough to cause other tests to fail with EADDRINUSE
because the same port number is used.

PR-URL: https://github.com/nodejs/node/pull/7045
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>

1 files changed, 3 insertions, 2 deletions

diff --git a/test/parallel/test-tls-honorcipherorder.js b/test/parallel/test-tls-honorcipherorder.js
index dd3ead8d42..81c2440fe2 100644
--- a/test/parallel/test-tls-honorcipherorder.js
+++ b/test/parallel/test-tls-honorcipherorder.js
@@ -37,7 +37,7 @@ function test(honorCipherOrder, clientCipher, expectedCipher, cb) {
     // it may hang for ~30 seconds in FIN_WAIT_1 state (at least on OSX).
     cleartextStream.end();
   });
-  server.listen(common.PORT, localhost, function() {
+  server.listen(0, localhost, function() {
     var coptions = {
       rejectUnauthorized: false,
       secureProtocol: SSL_Method
@@ -45,7 +45,8 @@ function test(honorCipherOrder, clientCipher, expectedCipher, cb) {
     if (clientCipher) {
       coptions.ciphers = clientCipher;
     }
-    var client = tls.connect(common.PORT, localhost, coptions, function() {
+    const port = this.address().port;
+    var client = tls.connect(port, localhost, coptions, function() {
       var cipher = client.getCipher();
       client.end();
       server.close();