diff options
author | Ethan Arrowood <ethan.arrowood@gmail.com> | 2016-12-01 10:29:05 -0600 |
---|---|---|
committer | James M Snell <jasnell@gmail.com> | 2016-12-05 08:34:41 -0800 |
commit | be1f52b498a9e58169efa6dd4f38fb1f9c949dec (patch) | |
tree | 3aba9ed393ebb6082c7bf5fd1bdc6e86f562dcea /test/parallel/test-tls-getcipher.js | |
parent | 9042a9161db563e113b530fc9aff7d6790b6a74f (diff) | |
download | android-node-v8-be1f52b498a9e58169efa6dd4f38fb1f9c949dec.tar.gz android-node-v8-be1f52b498a9e58169efa6dd4f38fb1f9c949dec.tar.bz2 android-node-v8-be1f52b498a9e58169efa6dd4f38fb1f9c949dec.zip |
test: updated tls-getcipher test
Changed var to ES6 syntax const/let.
Added common.mustCall function wrapper to all functions
called exactly once.
Changed assert.equal to assert.strictEqual.
PR-URL: https://github.com/nodejs/node/pull/9923
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'test/parallel/test-tls-getcipher.js')
-rw-r--r-- | test/parallel/test-tls-getcipher.js | 32 |
1 files changed, 16 insertions, 16 deletions
diff --git a/test/parallel/test-tls-getcipher.js b/test/parallel/test-tls-getcipher.js index 4ecacb1e9f..b5205d4877 100644 --- a/test/parallel/test-tls-getcipher.js +++ b/test/parallel/test-tls-getcipher.js @@ -1,37 +1,37 @@ 'use strict'; -var common = require('../common'); -var assert = require('assert'); +const common = require('../common'); if (!common.hasCrypto) { common.skip('missing crypto'); return; } -var tls = require('tls'); +const assert = require('assert'); +const tls = require('tls'); -var fs = require('fs'); -var cipher_list = ['AES128-SHA256', 'AES256-SHA256']; -var cipher_version_pattern = /TLS|SSL/; -var options = { +const fs = require('fs'); +const cipher_list = ['AES128-SHA256', 'AES256-SHA256']; +const cipher_version_pattern = /TLS|SSL/; +const options = { key: fs.readFileSync(common.fixturesDir + '/keys/agent2-key.pem'), cert: fs.readFileSync(common.fixturesDir + '/keys/agent2-cert.pem'), ciphers: cipher_list.join(':'), honorCipherOrder: true }; -var server = tls.createServer(options, - common.mustCall(function(cleartextStream) {})); +const server = tls.createServer(options, + common.mustCall(function(cleartextStream) {})); -server.listen(0, '127.0.0.1', function() { - var client = tls.connect({ +server.listen(0, '127.0.0.1', common.mustCall(function() { + const client = tls.connect({ host: '127.0.0.1', port: this.address().port, ciphers: cipher_list.join(':'), rejectUnauthorized: false - }, function() { - var cipher = client.getCipher(); - assert.equal(cipher.name, cipher_list[0]); + }, common.mustCall(function() { + const cipher = client.getCipher(); + assert.strictEqual(cipher.name, cipher_list[0]); assert(cipher_version_pattern.test(cipher.version)); client.end(); server.close(); - }); -}); + })); +})); |