diff options
author | Vse Mozhet Byt <vsemozhetbyt@gmail.com> | 2017-07-01 02:29:09 +0300 |
---|---|---|
committer | Vse Mozhet Byt <vsemozhetbyt@gmail.com> | 2017-07-04 12:41:49 +0300 |
commit | 2d2986ae72f2f5c63d95a94f05fa996d9f0609f1 (patch) | |
tree | 7a92ba45eb1ec041a2f9e40b0e63ac5c0be409c0 /test/parallel/test-tls-connect-address-family.js | |
parent | cc1a47dc6b94b2feb4de9e46be9333d81d537783 (diff) | |
download | android-node-v8-2d2986ae72f2f5c63d95a94f05fa996d9f0609f1.tar.gz android-node-v8-2d2986ae72f2f5c63d95a94f05fa996d9f0609f1.tar.bz2 android-node-v8-2d2986ae72f2f5c63d95a94f05fa996d9f0609f1.zip |
test: simplify test skipping
* Make common.skip() exit.
Also add common.printSkipMessage() for partial skips.
* Don't make needless things before skip
PR-URL: https://github.com/nodejs/node/pull/14021
Fixes: https://github.com/nodejs/node/issues/14016
Reviewed-By: Refael Ackermann <refack@gmail.com>
Diffstat (limited to 'test/parallel/test-tls-connect-address-family.js')
-rw-r--r-- | test/parallel/test-tls-connect-address-family.js | 13 |
1 files changed, 4 insertions, 9 deletions
diff --git a/test/parallel/test-tls-connect-address-family.js b/test/parallel/test-tls-connect-address-family.js index f22831f395..afacd5a390 100644 --- a/test/parallel/test-tls-connect-address-family.js +++ b/test/parallel/test-tls-connect-address-family.js @@ -1,14 +1,10 @@ 'use strict'; const common = require('../common'); -if (!common.hasCrypto) { +if (!common.hasCrypto) common.skip('missing crypto'); - return; -} -if (!common.hasIPv6) { +if (!common.hasIPv6) common.skip('no IPv6 support'); - return; -} const assert = require('assert'); const tls = require('tls'); @@ -36,10 +32,9 @@ function runTest() { dns.lookup('localhost', {family: 6, all: true}, (err, addresses) => { if (err) { - if (err.code === 'ENOTFOUND') { + if (err.code === 'ENOTFOUND') common.skip('localhost does not resolve to ::1'); - return; - } + throw err; } |