diff options
author | juggernaut451 <singhjug1994@gmail.com> | 2018-03-18 00:33:26 +0530 |
---|---|---|
committer | Ruben Bridgewater <ruben@bridgewater.de> | 2018-04-10 01:52:27 +0200 |
commit | d1156da815d878df9252cd0b0489c27c38e63511 (patch) | |
tree | 03b37ffc3905af3792eebf94939714451152f3c9 /test/parallel/test-tls-async-cb-after-socket-end.js | |
parent | cbc7eb7eecf8fa698ba3a02e1a73cb2db67daf89 (diff) | |
download | android-node-v8-d1156da815d878df9252cd0b0489c27c38e63511.tar.gz android-node-v8-d1156da815d878df9252cd0b0489c27c38e63511.tar.bz2 android-node-v8-d1156da815d878df9252cd0b0489c27c38e63511.zip |
test: refactor parallel/test-tls-async-cb-after-socket-end
PR-URL: https://github.com/nodejs/node/pull/18985
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Diffstat (limited to 'test/parallel/test-tls-async-cb-after-socket-end.js')
-rw-r--r-- | test/parallel/test-tls-async-cb-after-socket-end.js | 35 |
1 files changed, 17 insertions, 18 deletions
diff --git a/test/parallel/test-tls-async-cb-after-socket-end.js b/test/parallel/test-tls-async-cb-after-socket-end.js index 2e1fbe54ae..6ca38461fd 100644 --- a/test/parallel/test-tls-async-cb-after-socket-end.js +++ b/test/parallel/test-tls-async-cb-after-socket-end.js @@ -1,5 +1,4 @@ 'use strict'; - const common = require('../common'); if (!common.hasCrypto) common.skip('missing crypto'); @@ -7,60 +6,60 @@ const fixtures = require('../common/fixtures'); const SSL_OP_NO_TICKET = require('crypto').constants.SSL_OP_NO_TICKET; const tls = require('tls'); +// Check tls async callback after socket ends + const options = { secureOptions: SSL_OP_NO_TICKET, key: fixtures.readSync('test_key.pem'), cert: fixtures.readSync('test_cert.pem') }; -const server = tls.createServer(options, function(c) { -}); +const server = tls.createServer(options, common.mustCall()); let sessionCb = null; let client = null; -server.on('newSession', function(key, session, done) { +server.on('newSession', common.mustCall((key, session, done) => { done(); -}); +})); -server.on('resumeSession', function(id, cb) { +server.on('resumeSession', common.mustCall((id, cb) => { sessionCb = cb; - next(); -}); +})); -server.listen(0, function() { +server.listen(0, common.mustCall(() => { const clientOpts = { - port: this.address().port, + port: server.address().port, rejectUnauthorized: false, session: false }; - const s1 = tls.connect(clientOpts, function() { + const s1 = tls.connect(clientOpts, common.mustCall(() => { clientOpts.session = s1.getSession(); console.log('1st secure'); s1.destroy(); - const s2 = tls.connect(clientOpts, function(s) { + const s2 = tls.connect(clientOpts, (s) => { console.log('2nd secure'); s2.destroy(); - }).on('connect', function() { + }).on('connect', common.mustCall(() => { console.log('2nd connected'); client = s2; next(); - }); - }); -}); + })); + })); +})); function next() { if (!client || !sessionCb) return; client.destroy(); - setTimeout(function() { + setTimeout(common.mustCall(() => { sessionCb(); server.close(); - }, 100); + }), 100); } |