diff options
author | Brian White <mscdex@mscdex.net> | 2016-05-29 03:06:56 -0400 |
---|---|---|
committer | Brian White <mscdex@mscdex.net> | 2016-06-10 22:30:55 -0400 |
commit | 2bc7841d0fcdd066fe477873229125b6f003b693 (patch) | |
tree | 2816555ef6ad2fc828a75dc3c564f8faa2dee6c7 /test/parallel/test-timers-socket-timeout-removes-other-socket-unref-timer.js | |
parent | 624734e640717a826ab1a18845c083a638dc5ce6 (diff) | |
download | android-node-v8-2bc7841d0fcdd066fe477873229125b6f003b693.tar.gz android-node-v8-2bc7841d0fcdd066fe477873229125b6f003b693.tar.bz2 android-node-v8-2bc7841d0fcdd066fe477873229125b6f003b693.zip |
test: use random ports where possible
This helps to prevent issues where a failed test can keep a bound
socket open long enough to cause other tests to fail with EADDRINUSE
because the same port number is used.
PR-URL: https://github.com/nodejs/node/pull/7045
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
Diffstat (limited to 'test/parallel/test-timers-socket-timeout-removes-other-socket-unref-timer.js')
-rw-r--r-- | test/parallel/test-timers-socket-timeout-removes-other-socket-unref-timer.js | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/test/parallel/test-timers-socket-timeout-removes-other-socket-unref-timer.js b/test/parallel/test-timers-socket-timeout-removes-other-socket-unref-timer.js index a26b548385..8670c3c2b6 100644 --- a/test/parallel/test-timers-socket-timeout-removes-other-socket-unref-timer.js +++ b/test/parallel/test-timers-socket-timeout-removes-other-socket-unref-timer.js @@ -31,7 +31,7 @@ const server = net.createServer(function onClient(client) { } }); -server.listen(common.PORT, common.localhostIPv4, function() { +server.listen(0, common.localhostIPv4, function() { var nbClientsEnded = 0; function addEndedClient(client) { @@ -41,9 +41,9 @@ server.listen(common.PORT, common.localhostIPv4, function() { } } - const client1 = net.connect({ port: common.PORT }); + const client1 = net.connect({ port: this.address().port }); client1.on('end', addEndedClient); - const client2 = net.connect({ port: common.PORT }); + const client2 = net.connect({ port: this.address().port }); client2.on('end', addEndedClient); }); |