diff options
author | Jeremiah Senkpiel <fishrock123@rocketmail.com> | 2018-01-09 13:25:20 -0500 |
---|---|---|
committer | Jeremiah Senkpiel <fishrock123@rocketmail.com> | 2018-02-02 14:05:43 -0500 |
commit | 68783ae0b823c584f625c045a134bfff63f4d1b3 (patch) | |
tree | 3a52bf108a7e9e6e4a68f963c768544930f30c06 /test/parallel/test-timers-max-duration-warning.js | |
parent | 42258d7e54a4772dda3b3253c4b7cbca7175d360 (diff) | |
download | android-node-v8-68783ae0b823c584f625c045a134bfff63f4d1b3.tar.gz android-node-v8-68783ae0b823c584f625c045a134bfff63f4d1b3.tar.bz2 android-node-v8-68783ae0b823c584f625c045a134bfff63f4d1b3.zip |
timers: runtime-deprecate {un}enroll()
This was never a Very Good API, and generally just left so many open
ends for inconsistent behavior. The "optimization" benefit of this API
is little to none. Makes a starting step towards removing it so that in
the future timers, especially in their async_hooks interactions, can be
simplified.
PR-URL: https://github.com/nodejs/node/pull/18066
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Diffstat (limited to 'test/parallel/test-timers-max-duration-warning.js')
-rw-r--r-- | test/parallel/test-timers-max-duration-warning.js | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/test/parallel/test-timers-max-duration-warning.js b/test/parallel/test-timers-max-duration-warning.js index 712b56b8d2..1fc17b9741 100644 --- a/test/parallel/test-timers-max-duration-warning.js +++ b/test/parallel/test-timers-max-duration-warning.js @@ -11,13 +11,15 @@ function timerNotCanceled() { } process.on('warning', common.mustCall((warning) => { + if (warning.name === 'DeprecationWarning') return; + const lines = warning.message.split('\n'); assert.strictEqual(warning.name, 'TimeoutOverflowWarning'); assert.strictEqual(lines[0], `${OVERFLOW} does not fit into a 32-bit signed` + ' integer.'); assert.strictEqual(lines.length, 2); -}, 3)); +}, 4)); { |