test: use random ports where possible

This helps to prevent issues where a failed test can keep a bound
socket open long enough to cause other tests to fail with EADDRINUSE
because the same port number is used.

PR-URL: https://github.com/nodejs/node/pull/7045
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>

1 files changed, 6 insertions, 4 deletions

diff --git a/test/parallel/test-tcp-wrap.js b/test/parallel/test-tcp-wrap.js
index 93da3e5b3b..18b8fe401f 100644
--- a/test/parallel/test-tcp-wrap.js
+++ b/test/parallel/test-tcp-wrap.js
@@ -1,5 +1,5 @@
 'use strict';
-var common = require('../common');
+require('../common');
 var assert = require('assert');
 
 var TCP = process.binding('tcp_wrap').TCP;
@@ -7,12 +7,14 @@ var uv = process.binding('uv');
 
 var handle = new TCP();
 
-// Should be able to bind to the common.PORT
-var err = handle.bind('0.0.0.0', common.PORT);
+// Should be able to bind to the port
+var err = handle.bind('0.0.0.0', 0);
 assert.equal(err, 0);
 
 // Should not be able to bind to the same port again
-err = handle.bind('0.0.0.0', common.PORT);
+var out = {};
+handle.getsockname(out);
+err = handle.bind('0.0.0.0', out.port);
 assert.equal(err, uv.UV_EINVAL);
 
 handle.close();