aboutsummaryrefslogtreecommitdiff
path: root/test/parallel/test-stream2-transform.js
diff options
context:
space:
mode:
authorMatteo Collina <hello@matteocollina.com>2019-03-13 22:26:18 +0100
committerMatteo Collina <hello@matteocollina.com>2019-03-16 11:58:12 +0100
commit269103a0e5e30cc217bde1660087e87dfc722b8a (patch)
tree996d8d114dd8f98980c449bb99bac6e66f812c74 /test/parallel/test-stream2-transform.js
parentc5e619b8ffe9e1106a3e104cc138c8bc0324c1a7 (diff)
downloadandroid-node-v8-269103a0e5e30cc217bde1660087e87dfc722b8a.tar.gz
android-node-v8-269103a0e5e30cc217bde1660087e87dfc722b8a.tar.bz2
android-node-v8-269103a0e5e30cc217bde1660087e87dfc722b8a.zip
stream: fix regression introduced in #26059
In #26059, we introduced a bug that caused 'readable' to be nextTicked on EOF of a ReadableStream. This breaks the dicer module on CITGM. That change was partially reverted to still fix the bug in #25810 and not break dicer. See: https://github.com/nodejs/node/pull/26059 Fixes: https://github.com/nodejs/node/issues/25810 PR-URL: https://github.com/nodejs/node/pull/26643 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'test/parallel/test-stream2-transform.js')
-rw-r--r--test/parallel/test-stream2-transform.js14
1 files changed, 4 insertions, 10 deletions
diff --git a/test/parallel/test-stream2-transform.js b/test/parallel/test-stream2-transform.js
index 2590d5192f..b27b4116f3 100644
--- a/test/parallel/test-stream2-transform.js
+++ b/test/parallel/test-stream2-transform.js
@@ -321,16 +321,10 @@ const Transform = require('_stream_transform');
pt.end();
- // The next readable is emitted on the next tick.
- assert.strictEqual(emits, 0);
-
- process.on('nextTick', function() {
- assert.strictEqual(emits, 1);
- assert.strictEqual(pt.read(5).toString(), 'l');
- assert.strictEqual(pt.read(5), null);
-
- assert.strictEqual(emits, 1);
- });
+ assert.strictEqual(emits, 1);
+ assert.strictEqual(pt.read(5).toString(), 'l');
+ assert.strictEqual(pt.read(5), null);
+ assert.strictEqual(emits, 1);
}
{