test: enable linting for tests

Enable linting for the test directory. A number of changes was made so
all tests conform the current rules used by lib and src directories. The
only exception for tests is that unreachable (dead) code is allowed.

test-fs-non-number-arguments-throw had to be excluded from the changes
because of a weird issue on Windows CI.

PR-URL: https://github.com/nodejs/io.js/pull/1721
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

1 files changed, 11 insertions, 8 deletions

diff --git a/test/parallel/test-stream2-readable-wrap.js b/test/parallel/test-stream2-readable-wrap.js
index 71f8a28265..8e3e04b966 100644
--- a/test/parallel/test-stream2-readable-wrap.js
+++ b/test/parallel/test-stream2-readable-wrap.js
@@ -1,3 +1,4 @@
+'use strict';
 var common = require('../common');
 var assert = require('assert');
 
@@ -9,8 +10,9 @@ var testRuns = 0, completedRuns = 0;
 function runTest(highWaterMark, objectMode, produce) {
   testRuns++;
 
-  var old = new EE;
-  var r = new Readable({ highWaterMark: highWaterMark, objectMode: objectMode });
+  var old = new EE();
+  var r = new Readable({ highWaterMark: highWaterMark,
+                         objectMode: objectMode });
   assert.equal(r, r.wrap(old));
 
   var ended = false;
@@ -50,7 +52,8 @@ function runTest(highWaterMark, objectMode, produce) {
     }
   }
 
-  var w = new Writable({ highWaterMark: highWaterMark * 2, objectMode: objectMode });
+  var w = new Writable({ highWaterMark: highWaterMark * 2,
+                         objectMode: objectMode });
   var written = [];
   w._write = function(chunk, encoding, cb) {
     console.log('_write', chunk);
@@ -67,19 +70,19 @@ function runTest(highWaterMark, objectMode, produce) {
 
   flow();
 
-  function performAsserts() { 
+  function performAsserts() {
     assert(ended);
     assert(oldEnded);
     assert.deepEqual(written, expected);
   }
 }
 
-runTest(100, false, function(){ return new Buffer(100); });
-runTest(10, false, function(){ return new Buffer('xxxxxxxxxx'); });
-runTest(1, true, function(){ return { foo: 'bar' }; });
+runTest(100, false, function() { return new Buffer(100); });
+runTest(10, false, function() { return new Buffer('xxxxxxxxxx'); });
+runTest(1, true, function() { return { foo: 'bar' }; });
 
 var objectChunks = [ 5, 'a', false, 0, '', 'xyz', { x: 4 }, 7, [], 555 ];
-runTest(1, true, function(){ return objectChunks.shift() });
+runTest(1, true, function() { return objectChunks.shift(); });
 
 process.on('exit', function() {
   assert.equal(testRuns, completedRuns);