summaryrefslogtreecommitdiff
path: root/test/parallel/test-stream-writable-null.js
diff options
context:
space:
mode:
authorRuben Bridgewater <ruben@bridgewater.de>2018-02-09 02:32:04 +0100
committerRuben Bridgewater <ruben@bridgewater.de>2018-02-16 16:53:47 +0100
commitcaee112e52b64f4bc1118c4a5fa5ad7b4211efea (patch)
tree7b60b49da3f863917a23ebc94c00bf2f13cc1348 /test/parallel/test-stream-writable-null.js
parent4d3c3f039af08b954fbbba1e9a50979ffc98592b (diff)
downloadandroid-node-v8-caee112e52b64f4bc1118c4a5fa5ad7b4211efea.tar.gz
android-node-v8-caee112e52b64f4bc1118c4a5fa5ad7b4211efea.tar.bz2
android-node-v8-caee112e52b64f4bc1118c4a5fa5ad7b4211efea.zip
test: remove assert.doesNotThrow()
There is actually no reason to use `assert.doesNotThrow()` in the tests. If a test throws, just let the error bubble up right away instead of first catching it and then rethrowing it. PR-URL: https://github.com/nodejs/node/pull/18669 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Diffstat (limited to 'test/parallel/test-stream-writable-null.js')
-rw-r--r--test/parallel/test-stream-writable-null.js17
1 files changed, 9 insertions, 8 deletions
diff --git a/test/parallel/test-stream-writable-null.js b/test/parallel/test-stream-writable-null.js
index f1b91dee21..706141821b 100644
--- a/test/parallel/test-stream-writable-null.js
+++ b/test/parallel/test-stream-writable-null.js
@@ -27,14 +27,14 @@ common.expectsError(
}
);
-assert.doesNotThrow(() => {
+{
const m = new MyWritable({ objectMode: true }).on('error', (e) => {
assert.ok(e);
});
m.write(null, (err) => {
assert.ok(err);
});
-});
+}
common.expectsError(
() => {
@@ -47,24 +47,25 @@ common.expectsError(
}
);
-assert.doesNotThrow(() => {
+{
const m = new MyWritable().on('error', (e) => {
assert.ok(e);
});
m.write(false, (err) => {
assert.ok(err);
});
-});
+}
-assert.doesNotThrow(() => {
+{
const m = new MyWritable({ objectMode: true });
m.write(false, (err) => assert.ifError(err));
-});
-assert.doesNotThrow(() => {
+}
+
+{
const m = new MyWritable({ objectMode: true }).on('error', (e) => {
assert.ifError(e || new Error('should not get here'));
});
m.write(false, (err) => {
assert.ifError(err);
});
-});
+}